From patchwork Mon Mar 31 20:10:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Matthew Wilcox (Oracle)" X-Patchwork-Id: 14033935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C65EC3601B for ; Mon, 31 Mar 2025 20:13:20 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tzLVX-0000tX-4d; Mon, 31 Mar 2025 20:13:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tzLVV-0000sK-1M for linux-f2fs-devel@lists.sourceforge.net; Mon, 31 Mar 2025 20:13:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uPYDPe5bi5K9TZoWnww0axJYtK/8MBa6UKszp3TxOEk=; b=lv1Qqww5GWdMYaapCax5jrRInI E/DRH0voqvZK2mw458DMWcE3MRkWlJjcLaqm/KBxFVxI92A+Cy1EDTZ++YuI+WNd0e3lSR34qydOi jw8dag7F8JmzUFAJw8no8cDlN863q0oi+l6O4cgcX5dXw82pvL0ex8vA+Q8gJbMGnSyU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uPYDPe5bi5K9TZoWnww0axJYtK/8MBa6UKszp3TxOEk=; b=fmcK6VLIOuMSFpxSCLtPLwOd22 e43OPijoyMBlL5EYp7I0dW5ZN5P26dVLRnQu8uywhtTfRWO7tsnmjm18sUJIlJCUu6NgGvoyFF6Ps hzaToDAkhT41ZCt5lwks5PwkcEtFsaBXyt5Xy0SN6wtXvEnAk2+5mENZmUUmyK1ueXIc=; Received: from casper.infradead.org ([90.155.50.34]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tzLVV-0003Zh-4X for linux-f2fs-devel@lists.sourceforge.net; Mon, 31 Mar 2025 20:13:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=uPYDPe5bi5K9TZoWnww0axJYtK/8MBa6UKszp3TxOEk=; b=L6dyzuMrkWjM/91fMxnp/tDi5d OndRFXw5c1YxpL/Dn9X3IXk4InodB9FLWfwQakAy5vecbWGV61vbgrKPiS0quUzzxAmZShfcUQ4zX Sja3i1tliMCuYnfoWs6eEuYIUFG44wlWNjSRYhAV8WmdrH0g+F+15JQ56Y9y606zAVWTbF8JVeN04 0qqzMQIHEY8897qgYBmCP4ciAZBU+ktBStRB7SsjAl5y0a3FwIZz2lMcx+bYTy5pJScS52avrzQkx TpyRyz81u+6j/hvGC7pih0KmrnkO7thm11+Wo0Drai9hOwrn0VDzo03CppcR68NKgUXzT7Ug2DOnH rVRdr6YA==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzLVJ-00000004RcN-3JGZ; Mon, 31 Mar 2025 20:13:05 +0000 From: "Matthew Wilcox (Oracle)" To: Jaegeuk Kim , Chao Yu Date: Mon, 31 Mar 2025 21:10:54 +0100 Message-ID: <20250331201256.1057782-35-willy@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250331201256.1057782-1-willy@infradead.org> References: <20250331201256.1057782-1-willy@infradead.org> MIME-Version: 1.0 X-Headers-End: 1tzLVV-0003Zh-4X Subject: [f2fs-dev] [PATCH 034/153] f2fs: Use a folio in read_compacted_summaries() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Matthew Wilcox \(Oracle\)" , linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Get a folio instead of a page. Saves two hidden calls to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/f2fs/segment.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index aa0f2f243dba..61888496eaa9 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -4213,16 +4213,16 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi) struct f2fs_checkpoint *ckpt = F2FS_CKPT(sbi); struct curseg_info *seg_i; unsigned char *kaddr; - struct page *page; + struct folio *folio; block_t start; int i, j, offset; start = start_sum_block(sbi); - page = f2fs_get_meta_page(sbi, start++); - if (IS_ERR(page)) - return PTR_ERR(page); - kaddr = (unsigned char *)page_address(page); + folio = f2fs_get_meta_folio(sbi, start++); + if (IS_ERR(folio)) + return PTR_ERR(folio); + kaddr = folio_address(folio); /* Step 1: restore nat cache */ seg_i = CURSEG_I(sbi, CURSEG_HOT_DATA); @@ -4259,17 +4259,16 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi) SUM_FOOTER_SIZE) continue; - f2fs_put_page(page, 1); - page = NULL; + f2fs_folio_put(folio, true); - page = f2fs_get_meta_page(sbi, start++); - if (IS_ERR(page)) - return PTR_ERR(page); - kaddr = (unsigned char *)page_address(page); + folio = f2fs_get_meta_folio(sbi, start++); + if (IS_ERR(folio)) + return PTR_ERR(folio); + kaddr = folio_address(folio); offset = 0; } } - f2fs_put_page(page, 1); + f2fs_folio_put(folio, true); return 0; }