[6.12.y,11/60] rust: introduce `.clippy.toml`

Message ID	20250307225008.779961-12-ojeda@kernel.org
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFAE220D503; Fri, 7 Mar 2025 22:51:06 +0000 (UTC) From: Miguel Ojeda <ojeda@kernel.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, stable@vger.kernel.org Cc: Danilo Krummrich <dakr@kernel.org>, Alice Ryhl <aliceryhl@google.com>, Alyssa Ross <hi@alyssa.is>, NoisyCoil <noisycoil@disroot.org>, patches@lists.linux.dev, Miguel Ojeda <ojeda@kernel.org> Subject: [PATCH 6.12.y 11/60] rust: introduce `.clippy.toml` Date: Fri, 7 Mar 2025 23:49:18 +0100 Message-ID: <20250307225008.779961-12-ojeda@kernel.org> In-Reply-To: <20250307225008.779961-1-ojeda@kernel.org> References: <20250307225008.779961-1-ojeda@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	`alloc`, `#[expect]` and "Custom FFI" \| expand [6.12.y,00/60] `alloc`, `#[expect]` and "Custom FFI" [6.12.y,01/60] rust: workqueue: remove unneeded ``#[allow(clippy::new_ret_no_self)]` [6.12.y,02/60] rust: sort global Rust flags [6.12.y,03/60] rust: types: avoid repetition in `{As,From}Bytes` impls [6.12.y,04/60] rust: enable `clippy::undocumented_unsafe_blocks` lint [6.12.y,05/60] rust: enable `clippy::unnecessary_safety_comment` lint [6.12.y,06/60] rust: enable `clippy::unnecessary_safety_doc` lint [6.12.y,07/60] rust: enable `clippy::ignored_unit_patterns` lint [6.12.y,08/60] rust: enable `rustdoc::unescaped_backticks` lint [6.12.y,09/60] rust: init: remove unneeded `#[allow(clippy::disallowed_names)]` [6.12.y,10/60] rust: sync: remove unneeded `#[allow(clippy::non_send_fields_in_send_ty)]` [6.12.y,11/60] rust: introduce `.clippy.toml` [6.12.y,12/60] rust: replace `clippy::dbg_macro` with `disallowed_macros` [6.12.y,13/60] rust: provide proper code documentation titles [6.12.y,14/60] rust: enable Clippy's `check-private-items` [6.12.y,15/60] Documentation: rust: add coding guidelines on lints [6.12.y,16/60] rust: start using the `#[expect(...)]` attribute [6.12.y,17/60] Documentation: rust: discuss `#[expect(...)]` in the guidelines [6.12.y,18/60] rust: error: make conversion functions public [6.12.y,19/60] rust: error: optimize error type to use nonzero [6.12.y,20/60] rust: alloc: add `Allocator` trait [6.12.y,21/60] rust: alloc: separate `aligned_size` from `krealloc_aligned` [6.12.y,22/60] rust: alloc: rename `KernelAllocator` to `Kmalloc` [6.12.y,23/60] rust: alloc: implement `ReallocFunc` [6.12.y,24/60] rust: alloc: make `allocator` module public [6.12.y,25/60] rust: alloc: implement `Allocator` for `Kmalloc` [6.12.y,26/60] rust: alloc: add module `allocator_test` [6.12.y,27/60] rust: alloc: implement `Vmalloc` allocator [6.12.y,28/60] rust: alloc: implement `KVmalloc` allocator [6.12.y,29/60] rust: alloc: add __GFP_NOWARN to `Flags` [6.12.y,30/60] rust: alloc: implement kernel `Box` [6.12.y,31/60] rust: treewide: switch to our kernel `Box` type [6.12.y,32/60] rust: alloc: remove extension of std's `Box` [6.12.y,33/60] rust: alloc: add `Box` to prelude [6.12.y,34/60] rust: alloc: introduce `ArrayLayout` [6.12.y,35/60] rust: alloc: implement kernel `Vec` type [6.12.y,36/60] rust: alloc: implement `IntoIterator` for `Vec` [6.12.y,37/60] rust: alloc: implement `collect` for `IntoIter` [6.12.y,38/60] rust: treewide: switch to the kernel `Vec` type [6.12.y,39/60] rust: alloc: remove `VecExt` extension [6.12.y,40/60] rust: alloc: add `Vec` to prelude [6.12.y,41/60] rust: error: use `core::alloc::LayoutError` [6.12.y,42/60] rust: error: check for config `test` in `Error::name` [6.12.y,43/60] rust: alloc: implement `contains` for `Flags` [6.12.y,44/60] rust: alloc: implement `Cmalloc` in module allocator_test [6.12.y,45/60] rust: str: test: replace `alloc::format` [6.12.y,46/60] rust: alloc: update module comment of alloc.rs [6.12.y,47/60] kbuild: rust: remove the `alloc` crate and `GlobalAlloc` [6.12.y,48/60] MAINTAINERS: add entry for the Rust `alloc` module [6.12.y,49/60] drm/panic: avoid reimplementing Iterator::find [6.12.y,50/60] drm/panic: remove unnecessary borrow in alignment_pattern [6.12.y,51/60] drm/panic: prefer eliding lifetimes [6.12.y,52/60] drm/panic: remove redundant field when assigning value [6.12.y,53/60] drm/panic: correctly indent continuation of line in list item [6.12.y,54/60] drm/panic: allow verbose boolean for clarity [6.12.y,55/60] drm/panic: allow verbose version check [6.12.y,56/60] rust: kbuild: expand rusttest target for macros [6.12.y,57/60] rust: fix size_t in bindgen prototypes of C builtins [6.12.y,58/60] rust: map `__kernel_size_t` and friends also to usize/isize [6.12.y,59/60] rust: use custom FFI integer types [6.12.y,60/60] rust: alloc: Fix `ArrayLayout` allocations

Message ID

20250307225008.779961-12-ojeda@kernel.org

State

New

Headers

From: Miguel Ojeda <ojeda@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org
Cc: Danilo Krummrich <dakr@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Alyssa Ross <hi@alyssa.is>,
	NoisyCoil <noisycoil@disroot.org>,
	patches@lists.linux.dev,
	Miguel Ojeda <ojeda@kernel.org>
Subject: [PATCH 6.12.y 11/60] rust: introduce `.clippy.toml`
Date: Fri,  7 Mar 2025 23:49:18 +0100
Message-ID: <20250307225008.779961-12-ojeda@kernel.org>
In-Reply-To: <20250307225008.779961-1-ojeda@kernel.org>
References: <20250307225008.779961-1-ojeda@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

`alloc`, `#[expect]` and "Custom FFI" | expand

Commit Message

Miguel Ojeda March 7, 2025, 10:49 p.m. UTC

commit 7d56786edcbdf58b6367fd7f01d5861214ad1c95 upstream.

Some Clippy lints can be configured/tweaked. We will use these knobs to
our advantage in later commits.

This is done via a configuration file, `.clippy.toml` [1]. The file is
currently unstable. This may be a problem in the future, but we can adapt
as needed. In addition, we proposed adding Clippy to the Rust CI's RFL
job [2], so we should be able to catch issues pre-merge.

Thus introduce the file.

Link: https://doc.rust-lang.org/clippy/configuration.html [1]
Link: https://github.com/rust-lang/rust/pull/128928 [2]
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Tested-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20240904204347.168520-12-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 .clippy.toml | 1 +
 .gitignore   | 1 +
 MAINTAINERS  | 1 +
 Makefile     | 3 +++
 4 files changed, 6 insertions(+)
 create mode 100644 .clippy.toml

diff --git a/.clippy.toml b/.clippy.toml
new file mode 100644
index 000000000000..f66554cd5c45
--- /dev/null
+++ b/.clippy.toml
@@ -0,0 +1 @@ 
+# SPDX-License-Identifier: GPL-2.0
diff --git a/.gitignore b/.gitignore
index 56972adb5031..a61e4778d011 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,7 @@  modules.order
 # We don't want to ignore the following even if they are dot-files
 #
 !.clang-format
+!.clippy.toml
 !.cocciconfig
 !.editorconfig
 !.get_maintainer.ignore
diff --git a/MAINTAINERS b/MAINTAINERS
index 6bb4ec0c162a..f4e08a0851bd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20175,6 +20175,7 @@  B:	https://github.com/Rust-for-Linux/linux/issues
 C:	zulip://rust-for-linux.zulipchat.com
 P:	https://rust-for-linux.com/contributing
 T:	git https://github.com/Rust-for-Linux/linux.git rust-next
+F:	.clippy.toml
 F:	Documentation/rust/
 F:	rust/
 F:	samples/rust/
diff --git a/Makefile b/Makefile
index 8748aa1b2f79..43cc17c514dc 100644
--- a/Makefile
+++ b/Makefile
@@ -588,6 +588,9 @@  endif
 # Allows the usage of unstable features in stable compilers.
 export RUSTC_BOOTSTRAP := 1
 
+# Allows finding `.clippy.toml` in out-of-srctree builds.
+export CLIPPY_CONF_DIR := $(srctree)
+
 export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC HOSTPKG_CONFIG
 export RUSTC RUSTDOC RUSTFMT RUSTC_OR_CLIPPY_QUIET RUSTC_OR_CLIPPY BINDGEN
 export HOSTRUSTC KBUILD_HOSTRUSTFLAGS

[6.12.y,11/60] rust: introduce `.clippy.toml`

Commit Message

Patch