From patchwork Thu Nov 1 23:19:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10664653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0780E17DB for ; Thu, 1 Nov 2018 23:19:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0A312C515 for ; Thu, 1 Nov 2018 23:19:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D43982C518; Thu, 1 Nov 2018 23:19:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A2262C4F4 for ; Thu, 1 Nov 2018 23:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbeKBIYJ (ORCPT ); Fri, 2 Nov 2018 04:24:09 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:52532 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727749AbeKBIYJ (ORCPT ); Fri, 2 Nov 2018 04:24:09 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA1NJ5jI134452; Thu, 1 Nov 2018 23:19:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=lNo7Zj4Q6evLu8+UVHsOlhsmL4ScGLiwxmijx3PI6+Q=; b=I6SjPipCUoOahnpjN+GZoEXgbl47MqVkjlHKIlsgfag5qKalDzl9OCGnqvumpzguMrlo AH8e7eocWqeYfz0fo/6oRpMoUvrPr11nehBRv1x2EWgftp65bZcNNxp06Axh86MKT6lu ShbQmy910FOBL/7iBRvHeaITmftgrfpDtXGVFn2hV9WWHrT2UcW+4fCvmyPJ3qYSukWJ 11UuNLEAssiiBvn+PalUj9aHiSKFdnv2bbIKCfm6NJw966WPoygma+Lt3KGDAWiZh1xb v09kcNbp4t+9eVSRvtFTqc93bpxQX8dyO1EaKCpA21hIl/416K1wvGYdxB+MDcSzm6eW FA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2ncfyqbpqt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Nov 2018 23:19:05 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wA1NJ4j2010154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Nov 2018 23:19:05 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wA1NJ4ak030622; Thu, 1 Nov 2018 23:19:04 GMT Received: from localhost (/10.145.178.77) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 01 Nov 2018 16:19:04 -0700 Subject: [PATCH 0/8] fstests: fix quota failures on xfs From: "Darrick J. Wong" To: guaneryu@gmail.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Date: Thu, 01 Nov 2018 16:19:02 -0700 Message-ID: <154111434286.6577.15010861884505931015.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9064 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=894 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811010194 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi all, Several months ago I tried testing xfs with quotas enabled and was surprised at the number of failures. Since then I've been on a bug hunt to triage the mess, and the following series fixes some of the low hanging fruit. Some of these are minor behavioral variations when quota are enabled, and other fixes upgrade old v4 tests to work on v5 filesystems. To reproduce the results, run xfstests with 'MOUNT_OPTIONS="-o usrquota,grpquota,prjquota"' on a v5 filesystem. Strike the ',grpquota' on a v4 filesystem. The first patch fixes the sporadic quota count failures when testing XFS with quotas by replacing the xfs_spaceman call that cleans out (only) speculative preallocations with a umount/mount pair that forcibly cleans out /all/ preallocations and delayed allocations. The second patch fixes bugs in a couple of tests that use error injection to test log recovery paths but don't succeed in directly causing the error to trip. The third patch works around the fact that mounting xfs with quotas requires a writable block device even for a ro mount, which leads to a slightly different error message from the mount call. Patch 4 and 5 fix the dump and restore tests to handle the case that quota inodes get sent along with dumps when quotas are enabled. Patch 6 updates xfs/205 to work with v5 filesystems. Patch 7 changes tests that require specific quota mount options to clear out the background quota mount options so that we test with /exactly/ the set of mount options. Patch 8 filters v5 mount options out of tests that format v4 filesystems on the scratch device. --D