| Message ID | 156394159426.1850833.16316913520596851191.stgit@magnolia (mailing list archive) |
|---|---|
| Headers | show |
| Series | xfs: fixes and new tests for bulkstat v5 | expand |
Hi XFS folks, On Tue, Jul 23, 2019 at 09:13:14PM -0700, Darrick J. Wong wrote: > Hi all, > > Fix some problems introduced by the creation of the V5 bulkstat ioctl, > and then add some new tests to make sure the new libxfrog bulkstat > wrappers work fine with both the new v5 ioctl and emulating it with the > old v1 ioctl. I may need some help on reviewing this patchset, especially the new bulkstat tests :) Thanks in advance! But I'd suggest split the last patch into two patches, one introduces & uses the new helper, the other one adds new tests. Also, it misses a new entry in .gitignore file. Thanks, Eryu > > If you're going to start using this mess, you probably ought to just > pull from my git trees, which are linked below. > > This is an extraordinary way to destroy everything. Enjoy! > Comments and questions are, as always, welcome. > > --D > > kernel git tree: > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=bulkstat-v5 > > xfsprogs git tree: > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=bulkstat-v5 > > fstests git tree: > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=bulkstat-v5
On Sun, Jul 28, 2019 at 07:26:35PM +0800, Eryu Guan wrote: > Hi XFS folks, > > On Tue, Jul 23, 2019 at 09:13:14PM -0700, Darrick J. Wong wrote: > > Hi all, > > > > Fix some problems introduced by the creation of the V5 bulkstat ioctl, > > and then add some new tests to make sure the new libxfrog bulkstat > > wrappers work fine with both the new v5 ioctl and emulating it with the > > old v1 ioctl. > > I may need some help on reviewing this patchset, especially the new > bulkstat tests :) Thanks in advance! Let me know if you have any questions. :) > But I'd suggest split the last patch into two patches, one introduces & > uses the new helper, the other one adds new tests. Also, it misses a new > entry in .gitignore file. Oops, will fix. --D > Thanks, > Eryu > > > > > If you're going to start using this mess, you probably ought to just > > pull from my git trees, which are linked below. > > > > This is an extraordinary way to destroy everything. Enjoy! > > Comments and questions are, as always, welcome. > > > > --D > > > > kernel git tree: > > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=bulkstat-v5 > > > > xfsprogs git tree: > > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=bulkstat-v5 > > > > fstests git tree: > > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=bulkstat-v5