[PATCHSET,v2,0/3] fstests: refactor ext4-specific code

Message

Darrick J. Wong Aug. 9, 2022, 9 p.m. UTC

Hi all,

This series aims to make it so that fstests can install device mapper
filters for external log devices.  Before we can do that, however, we
need to change fstests to pass the device path of the jbd2 device to
mount and mkfs.  Before we can do /that/, refactor all the ext4-specific
code out of common/rc into a separate common/ext4 file.

v2: fix _scratch_mkfs_sized for ext4, don't clutter up the outputs

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=refactor-ext4-helpers
---
 common/config |    4 +
 common/ext4   |  193 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 common/rc     |  186 ++++---------------------------------------------------
 common/xfs    |   23 +++++++
 4 files changed, 233 insertions(+), 173 deletions(-)
 create mode 100644 common/ext4

Comments

Zorro Lang Aug. 15, 2022, 9:18 a.m. UTC | #1

On Tue, Aug 09, 2022 at 02:00:41PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> This series aims to make it so that fstests can install device mapper
> filters for external log devices.  Before we can do that, however, we
> need to change fstests to pass the device path of the jbd2 device to
> mount and mkfs.  Before we can do /that/, refactor all the ext4-specific
> code out of common/rc into a separate common/ext4 file.
> 
> v2: fix _scratch_mkfs_sized for ext4, don't clutter up the outputs
> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.

Two weeks passed, this patchset is good to me, I'd like to merge this patchset
with "[PATCH 1/1] dmerror: support external log and realtime devices" together
this week.

Reviewed-by: Zorro Lang <[e-mail]>

> 
> --D
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=refactor-ext4-helpers
> ---
>  common/config |    4 +
>  common/ext4   |  193 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  common/rc     |  186 ++++---------------------------------------------------
>  common/xfs    |   23 +++++++
>  4 files changed, 233 insertions(+), 173 deletions(-)
>  create mode 100644 common/ext4
>