[v2,0/4] overlay: enhance fsck.overlay test cases

Message

Zhang Yi Oct. 16, 2018, 7:45 a.m. UTC

Hi all,

These are the second version of fsck.overlay[1] program related patch set
(the first one was posted about two mounths ago[2], sorry for the late).
I have fix all comments as Amir suggested and looks fine after test.

The first two patches correct the exit code and fix the tests failure
with master branch of fsck.overlay, and the last two patches were just
want to test stability and exception handling processes.

Hi Amir,

Patch 1 and 2 will fix the test failure you mentioned yesterday when you
run -g overlay/fsck with fsck.overlay's master branch. I am very grateful
if you can give a review.

Thanks,
Yi.

Changes from v1:
 - split patch 2 from patch 1 for readable.
 - move exit code definitions from common/config to common/overlay.
 - factor out a common function _run_check_fsck() to fsck and check
   return value.
 - fix some mistakes in patch 3 and 4.

[1] https://github.com/hisilicon/overlayfs-progs/commits/master
[2] https://www.spinics.net/lists/fstests/msg10267.html

zhangyi (F) (4):
  overlay: correct fsck.overlay exit code
  overlay: fix exit code for some fsck.overlay valid cases
  overlay: add fsck.overlay stress test
  overlay: add fsck.overlay exception tests

 common/overlay        |  37 ++++++++-
 tests/overlay/045     |  46 ++++++-----
 tests/overlay/046     |  49 ++++++------
 tests/overlay/056     |   9 +--
 tests/overlay/062     |  84 +++++++++++++++++++
 tests/overlay/062.out |   2 +
 tests/overlay/063     | 217 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/overlay/063.out |  10 +++
 tests/overlay/group   |   2 +
 9 files changed, 403 insertions(+), 53 deletions(-)
 create mode 100755 tests/overlay/062
 create mode 100644 tests/overlay/062.out
 create mode 100755 tests/overlay/063
 create mode 100644 tests/overlay/063.out

Comments

Amir Goldstein Oct. 16, 2018, 9:27 a.m. UTC | #1

On Tue, Oct 16, 2018 at 10:32 AM zhangyi (F) <[e-mail]> wrote:
>
> Hi all,
>
> These are the second version of fsck.overlay[1] program related patch set
> (the first one was posted about two mounths ago[2], sorry for the late).

Oh right. I managed to forget about that...
Thanks for following up.

Amir.

Amir Goldstein Oct. 16, 2018, 12:39 p.m. UTC | #2

On Tue, Oct 16, 2018 at 12:27 PM Amir Goldstein <[e-mail]> wrote:
>
> On Tue, Oct 16, 2018 at 10:32 AM zhangyi (F) <[e-mail]> wrote:
> >
> > Hi all,
> >
> > These are the second version of fsck.overlay[1] program related patch set
> > (the first one was posted about two mounths ago[2], sorry for the late).
>
> Oh right. I managed to forget about that...
> Thanks for following up.
>

Zhangyi,

For the next submission, please CC  linux-unionfs.
I bet folks are interested to know about progress with fsck.overlay.

And if you can provide a public branch with the tests, that would be nice.

Thanks,
Amir.

Zhang Yi Oct. 18, 2018, 3:50 a.m. UTC | #3

On 2018/10/16 20:39, Amir Goldstein Wrote:
> On Tue, Oct 16, 2018 at 12:27 PM Amir Goldstein <[e-mail]> wrote:
>>
>> On Tue, Oct 16, 2018 at 10:32 AM zhangyi (F) <[e-mail]> wrote:
>>>
>>> Hi all,
>>>
>>> These are the second version of fsck.overlay[1] program related patch set
>>> (the first one was posted about two mounths ago[2], sorry for the late).
>>
>> Oh right. I managed to forget about that...
>> Thanks for following up.
>>
> 
> Zhangyi,
> 
> For the next submission, please CC  linux-unionfs.
> I bet folks are interested to know about progress with fsck.overlay.
> 
> And if you can provide a public branch with the tests, that would be nice.
> 
Hi, Amir

Thanks for your comments, will do.

Thanks,
Yi.