[0/4] Assign a few generic tests to additional groups

Message

Vladimir Zapolskiy April 8, 2020, 1:56 p.m. UTC

The rationale behind the proposed changes is to correct and improve
granularity of some generic tests, so it becomes possible to control
lists of run tests better, if there is given additional information
about a test environment and tested filesystems.

Vladimir Zapolskiy (4):
  Add generic/459 test to freeze group of tests
  Add generic/482 test to thin group of tests
  Add generic/529 test to acl group of tests
  Add generic/530 test to shutdown group of tests

 tests/generic/group | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Zorro Lang April 12, 2020, 6:38 a.m. UTC | #1

On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
> The rationale behind the proposed changes is to correct and improve
> granularity of some generic tests, so it becomes possible to control
> lists of run tests better, if there is given additional information
> about a test environment and tested filesystems.
> 
> Vladimir Zapolskiy (4):
>   Add generic/459 test to freeze group of tests
>   Add generic/482 test to thin group of tests
>   Add generic/529 test to acl group of tests
>   Add generic/530 test to shutdown group of tests

That's fine for me, to set more sub-cases in proper groups. Due to generally
when someone writes a case, we don't take care of its group list so much.

> 
>  tests/generic/group | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
>

Eryu Guan April 12, 2020, 11:16 a.m. UTC | #2

On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
> The rationale behind the proposed changes is to correct and improve
> granularity of some generic tests, so it becomes possible to control
> lists of run tests better, if there is given additional information
> about a test environment and tested filesystems.

Thanks for doing this! I think we could group these changes in a single
patch. Could you please resend with a single patch that does all the
group changes?

Thanks,
Eryu

> 
> Vladimir Zapolskiy (4):
>   Add generic/459 test to freeze group of tests
>   Add generic/482 test to thin group of tests
>   Add generic/529 test to acl group of tests
>   Add generic/530 test to shutdown group of tests
> 
>  tests/generic/group | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
>

Vladimir Zapolskiy April 13, 2020, 7:23 a.m. UTC | #3

On 4/12/20 2:16 PM, Eryu Guan wrote:
> On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
>> The rationale behind the proposed changes is to correct and improve
>> granularity of some generic tests, so it becomes possible to control
>> lists of run tests better, if there is given additional information
>> about a test environment and tested filesystems.
> 
> Thanks for doing this! I think we could group these changes in a single
> patch. Could you please resend with a single patch that does all the
> group changes?

Sure, will do.

Thank you for review!

--
Best wishes,
Vladimir