From patchwork Mon Jan 18 06:20:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Babu R X-Patchwork-Id: 12026589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BC7C433E0 for ; Mon, 18 Jan 2021 06:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 313E522513 for ; Mon, 18 Jan 2021 06:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731528AbhARGV2 (ORCPT ); Mon, 18 Jan 2021 01:21:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730149AbhARGVZ (ORCPT ); Mon, 18 Jan 2021 01:21:25 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43039C061573; Sun, 17 Jan 2021 22:20:44 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id b8so8087306plx.0; Sun, 17 Jan 2021 22:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9Umf0xVqSWywdJ0NoJrT07PvCefqT4zm3CNrTEo21qs=; b=RHZ1XG5D9EzPMyJNpQ5Z2v2eH2zQe3w36m0c5QzGi7q06TQLjH9PJREtFvbAvy2jAa WO8TBZAFBAoVIumWxVfqiQBED0yetDNoR76ZiZzyGxh/+LVttD83kH92cEkDnWbThuM0 Dwdp1qQeNOaG7d35WlUr8lN6kc2Iom3hqtalxiX5tS7981hC7q/+2Fi33hgJmozakjnE JXSy01MgllEMOALW9i4008CuukKSAbAV7doL61DRGcUiHLK5ihJpZkEcjpsONKr08QXA AOhyxOn5QGflfMwY+weVeZxGop3TYWiRflt7HiM1O3+CTXn2hMx6CXQCckOsjaysyxpy Ih0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9Umf0xVqSWywdJ0NoJrT07PvCefqT4zm3CNrTEo21qs=; b=b+pyLF0Lsg4cHbJLQp8r7QaozQvoZQkWGz/sc5JkCVFhZvnFFLxxMyEapEZvoQTGV6 0G/FWVBlRfAN2OSVQjKUiZnWS9XSdV3DXdDpEHuzYrapzInHg+K8aPmFGdZ26PSFu6kg mNwUXTOj+9BEQy9Lsc+Tke3vxT6lWd5P4essyy7UcG+BEmiW12LssRO2C03QDnuOGKWw SrrqIGLVVwrpopJwUUvwOVKTrX16wyE25js7GAwUsPjwJKpzYID44RGmAaLhquIPplvZ Utgs8R5zfAYsbDjiW/uHIZNxG1A7/x/mJR0o3mR+T6X1Jhz6ZFKyPzsnWHbpExnmpewH kwpw== X-Gm-Message-State: AOAM531WBI2Vq/MaHElhMjxA5y9XyG1fi+7bSRkr/+OcKPfFCla6k6hG xHWwyDEmK+Yx1ca1ZvpXQgTPwJrYfOg= X-Google-Smtp-Source: ABdhPJzmQ+TAZ8GfYmbMhwHsS8A4Gaonqqy3OjNM2CkZydFnIlVKXyEsquCNtbL30F6lAnnF869MIA== X-Received: by 2002:a17:90a:5303:: with SMTP id x3mr25269091pjh.54.1610950843679; Sun, 17 Jan 2021 22:20:43 -0800 (PST) Received: from localhost.localdomain ([122.179.96.31]) by smtp.gmail.com with ESMTPSA id t1sm14608423pfq.154.2021.01.17.22.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 22:20:43 -0800 (PST) From: Chandan Babu R To: fstests@vger.kernel.org Cc: Chandan Babu R , linux-xfs@vger.kernel.org, darrick.wong@oracle.com, djwong@kernel.org Subject: [PATCH V4 00/11] xfs: Tests to verify inode fork extent count overflow detection Date: Mon, 18 Jan 2021 11:50:11 +0530 Message-Id: <20210118062022.15069-1-chandanrlinux@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org The patchset at https://lore.kernel.org/linux-xfs/20210110160720.3922965-1-chandanrlinux@gmail.com/T/ added support for XFS to detect inode extent count overflow when performing various filesystem operations. The patchset also added new error injection tags for, 1. Reducing maximum extent count to 10. 2. Allocating only single block sized extents. The corresponding code for xfsprogs can be obtained from https://lore.kernel.org/linux-xfs/20201104114900.172147-1-chandanrlinux@gmail.com/. The patches posted along with this cover letter add tests to verify the correctness of in-kernel inode extent count overflow detection mechanism. These patches can also be obtained from https://github.com/chandanr/xfstests.git at branch extent-overflow-tests. Changelog: V3 -> V4: 1. Rebase on fstests' latest master branch. V2 -> V3: 1. Kernel's max pseudo extent count is once again set to 10. Hence change the tests back to using 10 as the maximum extent count. 2. The following tests associated with directories have been removed since directory remove and rename operations are not expected to fail (with -EFBIG error code) in low inode extent count scenarios: - Populate source directory and mv one entry to destination directory. - Populate a directory and remove one entry. V1 -> V2: 1. Obtain extent count for inodes accessible through filesystem path names via "xfs_io -c 'stat' ..." command line. This gets rid of unmount/mount cycles from most of the tests. 2. Use _fill_fs() to consume free space of a filesystem. 3. Use _scratch_inject_error() helper to enable/disable error tags. 4. Use sizeof(struct xfs_dqblk) to calculate number of quotas inside one filesystem block. 5. Write once to every block of the quota inode instead of sequentially filling up each block. 6. Use _get_file_block_size() for tests involving regular files. 7. Modify tests to suit the new pseudo max extent count of 35. 8. Replace xfs_io with $XFS_IO_PROG. 9. Remove code that extended a realtime file since this takes the same path as direct I/O to a regular file. 10. For xattr, do not execute test script when block size is < 4k. 11. Add code to test if removing an xattr from a full attribute fork succeeds. 12. Add code to test if removing a file whose attribute fork is full succeeds. 13. Add code to test if removing a entry from a full directory succeeds. 14. Add code to test if removing a full directory succeeds. 15. Writing to unwritten extents: Integrate buffered and direct I/O tests into a for loop. 16. Writing to a shared extent test: Add test to check funshare operation. 17. Use _scale_fsstress_args() to scale values for "-p" and "-n" arguments for fsstress. Chandan Babu R (11): common/xfs: Add a helper to get an inode fork's extent count xfs: Check for extent overflow when trivally adding a new extent xfs: Check for extent overflow when growing realtime bitmap/summary inodes xfs: Check for extent overflow when punching a hole xfs: Check for extent overflow when adding/removing xattrs xfs: Check for extent overflow when adding/removing dir entries xfs: Check for extent overflow when writing to unwritten extent xfs: Check for extent overflow when moving extent from cow to data fork xfs: Check for extent overflow when remapping an extent xfs: Check for extent overflow when swapping extents xfs: Stress test with bmap_alloc_minlen_extent error tag enabled common/xfs | 22 ++++++ tests/xfs/522 | 173 ++++++++++++++++++++++++++++++++++++++++++ tests/xfs/522.out | 20 +++++ tests/xfs/523 | 119 +++++++++++++++++++++++++++++ tests/xfs/523.out | 11 +++ tests/xfs/524 | 84 +++++++++++++++++++++ tests/xfs/524.out | 19 +++++ tests/xfs/525 | 141 +++++++++++++++++++++++++++++++++++ tests/xfs/525.out | 18 +++++ tests/xfs/526 | 186 ++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/526.out | 17 +++++ tests/xfs/527 | 89 ++++++++++++++++++++++ tests/xfs/527.out | 11 +++ tests/xfs/528 | 110 +++++++++++++++++++++++++++ tests/xfs/528.out | 12 +++ tests/xfs/529 | 82 ++++++++++++++++++++ tests/xfs/529.out | 8 ++ tests/xfs/530 | 109 +++++++++++++++++++++++++++ tests/xfs/530.out | 13 ++++ tests/xfs/531 | 84 +++++++++++++++++++++ tests/xfs/531.out | 7 ++ tests/xfs/group | 10 +++ 22 files changed, 1345 insertions(+) create mode 100755 tests/xfs/522 create mode 100644 tests/xfs/522.out create mode 100755 tests/xfs/523 create mode 100644 tests/xfs/523.out create mode 100755 tests/xfs/524 create mode 100644 tests/xfs/524.out create mode 100755 tests/xfs/525 create mode 100644 tests/xfs/525.out create mode 100755 tests/xfs/526 create mode 100644 tests/xfs/526.out create mode 100755 tests/xfs/527 create mode 100644 tests/xfs/527.out create mode 100755 tests/xfs/528 create mode 100644 tests/xfs/528.out create mode 100755 tests/xfs/529 create mode 100644 tests/xfs/529.out create mode 100755 tests/xfs/530 create mode 100644 tests/xfs/530.out create mode 100755 tests/xfs/531 create mode 100644 tests/xfs/531.out