[v5,0/2] Add support for using liburing xattr

Message

Stefan Roesch Dec. 20, 2021, 6:15 p.m. UTC

This adds support for using the xattr implementation in liburing.

Patch 1: fstress: add suport for using liburing setxattr
  Uses the liburing setxattr implementation in fsstress.

Patch 2: fstress: add suport for using liburing getxattr
  Uses the liburing getxattr implementation in fsstress.

There are two additional patch series related to this:
- io_uring: add xattr support
- liburing: add xattr support

---
V5: - fix some whitespace issues, order enum definition in correct
      position and rebase
V4: - fix a whitespace/tab issue
V3: - Rebased patch series.
V2: - Introduce dedicated functions for uring getxattr and
      uring setxattr, so they are not automatically linked
      in if liburing is available.

Stefan Roesch (2):
  fstress: add suport for using liburing setxattr
  fstress: add suport for using liburing getxattr

 ltp/fsstress.c | 244 +++++++++++++++++++++++++++++++++++--------------
 1 file changed, 177 insertions(+), 67 deletions(-)


base-commit: 58e358032ac1f50acdb66615c04875d5375a6053

Comments

Eryu Guan Dec. 25, 2021, 1:40 p.m. UTC | #1

On Mon, Dec 20, 2021 at 10:15:38AM -0800, Stefan Roesch wrote:
> This adds support for using the xattr implementation in liburing.
> 
> Patch 1: fstress: add suport for using liburing setxattr
>   Uses the liburing setxattr implementation in fsstress.
> 
> Patch 2: fstress: add suport for using liburing getxattr
>   Uses the liburing getxattr implementation in fsstress.
> 
> There are two additional patch series related to this:
> - io_uring: add xattr support
> - liburing: add xattr support

I think it may take some time for distributions to pick up this liburing
xattr support, and before that we fail to compile fsstress due to
undefined functions as io_uring_prep_setxattr(). Maybe we should check
if current liburing supports xattr and otherwise use our local
implementation? So this patchset won't be blocked.

Thanks,
Eryu

> 
> ---
> V5: - fix some whitespace issues, order enum definition in correct
>       position and rebase
> V4: - fix a whitespace/tab issue
> V3: - Rebased patch series.
> V2: - Introduce dedicated functions for uring getxattr and
>       uring setxattr, so they are not automatically linked
>       in if liburing is available.
> 
> Stefan Roesch (2):
>   fstress: add suport for using liburing setxattr
>   fstress: add suport for using liburing getxattr
> 
>  ltp/fsstress.c | 244 +++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 177 insertions(+), 67 deletions(-)
> 
> 
> base-commit: 58e358032ac1f50acdb66615c04875d5375a6053
> -- 
> 2.30.2