[5.10,CANDIDATE,0/7] xfs stable candidate patches for 5.10.y (part 3)

Message

Amir Goldstein June 6, 2022, 4:05 p.m. UTC

Hi all!

This is the 3rd part of a collection of stable patch candidates that
I collected from xfs releases v5.11..v5.18.

Part #1 is already in 5.10.120 and part #2 has been posted to stable.

The patches in this part are from circa v5.12..v5.13.

They have been soaking in kdevops for over a week with no regressions
from baseline observed.

There are four user visible fixes in this part, one patch for dependency
("rename variable mp") and two patches to improve testability of LTS.

Specifically, I selected the fix ("use current->journal_info for
detecting transaction recursion") after I got a false positive assert
while testing LTS kernel with XFS_DEBUG and at another incident, it
helped me triage a regression that would have been harder to trace
back to the offending code otherwise.

It is worth noting that one patch from v5.13 did cause a regression
and was removed from the stable candidates queue during early testing -
0fe0bbe00a6f ("xfs: bunmapi has unnecessary AG lock ordering issues").

When I did a post mortem on a patch that I missed for part #2, I started
off on the wrong foot with Dave, so it is important for me to say this:
Although I had wrongly selected this fix, all the information I needed
to make the right decision was in the commit message, I just did not
understand it at the time that I selected the patch.

But when my tests had detected hangs on test xfs/299, that quickly lead
me to the mention of xfs/299 in the commit message and then I understood
that the fix was incorrect without "deferred inode inactivation" series
from 5.13-rc1.

I would like to thank Samsung and Luis for the resources and efforts
that make this work possible.

Your inputs on these stable candidates are most welcome!

Thanks,
Amir.


Anthony Iliopoulos (1):
  xfs: fix xfs_trans slab cache name

Darrick J. Wong (1):
  xfs: fix xfs_reflink_unshare usage of filemap_write_and_wait_range

Dave Chinner (2):
  xfs: use current->journal_info for detecting transaction recursion
  xfs: update superblock counters correctly for !lazysbcount

Gao Xiang (1):
  xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX

Pavel Reichl (2):
  xfs: rename variable mp to parsing_mp
  xfs: Skip repetitive warnings about mount options

 fs/iomap/buffered-io.c    |   7 ---
 fs/xfs/libxfs/xfs_btree.c |  12 +++-
 fs/xfs/libxfs/xfs_sb.c    |  16 ++++-
 fs/xfs/xfs_aops.c         |  17 +++++-
 fs/xfs/xfs_error.c        |   2 +
 fs/xfs/xfs_reflink.c      |   3 +-
 fs/xfs/xfs_super.c        | 120 +++++++++++++++++++++-----------------
 fs/xfs/xfs_trans.c        |  23 +++-----
 fs/xfs/xfs_trans.h        |  30 ++++++++++
 9 files changed, 148 insertions(+), 82 deletions(-)