| Message ID | 20220613113142.4338-1-lhenriques@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Two xattrs-related fixes for ceph | expand |
On 6/13/22 7:31 PM, Luís Henriques wrote: > Hi! > > A bug fix in ceph has made some changes in the way xattr limits are > enforced on the client side. This requires some fixes on tests > generic/020 and generic/486. > > * Changes since v2: > > - patch 0001: > Add logic to compute the *real* maximum. Kudos to David Disseldorp > for providing the right incantation to do the maths. Also split > _attr_get_max() in two, so that they can be invoked from different > places in the test script. > > - patch 002: > attr_replace_test now has an extra param as suggested by Dave Chinner, > and added fs-specific logic to the script. No need to have an exact > maximum in this test, a big-enough value suffices. > > * Changes since v1: > > - patch 0001: > Set the max size for xattrs values to a 65000, so that it is close to > the maximum, but still able to accommodate any pre-existing xattr > > - patch 0002: > Same thing as patch 0001, but in a more precise way: actually take > into account the exact sizes for name+value of a pre-existing xattr. > > Luís Henriques (2): > generic/020: adjust max_attrval_size for ceph > generic/486: adjust the max xattr size > > src/attr_replace_test.c | 30 ++++++++++++++++++++++++++---- > tests/generic/020 | 33 +++++++++++++++++++++++++-------- > tests/generic/486 | 11 ++++++++++- > 3 files changed, 61 insertions(+), 13 deletions(-) > This series looks good to me. Reviewed-by: Xiubo Li <xiubli@redhat.com>
Hi! A bug fix in ceph has made some changes in the way xattr limits are enforced on the client side. This requires some fixes on tests generic/020 and generic/486. * Changes since v2: - patch 0001: Add logic to compute the *real* maximum. Kudos to David Disseldorp for providing the right incantation to do the maths. Also split _attr_get_max() in two, so that they can be invoked from different places in the test script. - patch 002: attr_replace_test now has an extra param as suggested by Dave Chinner, and added fs-specific logic to the script. No need to have an exact maximum in this test, a big-enough value suffices. * Changes since v1: - patch 0001: Set the max size for xattrs values to a 65000, so that it is close to the maximum, but still able to accommodate any pre-existing xattr - patch 0002: Same thing as patch 0001, but in a more precise way: actually take into account the exact sizes for name+value of a pre-existing xattr. Luís Henriques (2): generic/020: adjust max_attrval_size for ceph generic/486: adjust the max xattr size src/attr_replace_test.c | 30 ++++++++++++++++++++++++++---- tests/generic/020 | 33 +++++++++++++++++++++++++-------- tests/generic/486 | 11 ++++++++++- 3 files changed, 61 insertions(+), 13 deletions(-)