mbox series

[v2,0/3] aborted fstests may leave frozen fs behind

Message ID 20220621173729.2135249-1-amir73il@gmail.com (mailing list archive)
Headers show
Series aborted fstests may leave frozen fs behind | expand


Amir Goldstein June 21, 2022, 5:37 p.m. UTC

As discussed on v1, this series fixes cleanup routines of
freeze tests without adding auto-cleanup in check.

I also took a closer look at some test cleanups and handled the
kill of background processes after unfreeze.

I tested that all the tests in the 'freeze' group that I modified
run to completion with no regressions.

I did not try to interrupt all the rest of the tests, because
interrupting a test at exact time that it is frozen is quite hard.

I did test that interrupting xfs/517 several times did not leave the fs
frozen.  Before the changes, it was rather easy to get it to leave a
frozen fs behind, because the freeze_loop() keeps the fs frozen around
half of the time that the test is running.


Changes since v1:
- Remove auto-cleanup in check
- Add more kill+wait in cleanups where needed
- Change the cleanup routines of the freeze_loops

Amir Goldstein (3):
  fstests: add missing _require_freeze() to tests
  fstests: unfreeze fs on cleanup routines
  xfs/{422,517}: kill background jobs on test termination

 tests/generic/068 | 14 ++++++++++----
 tests/generic/085 |  3 +++
 tests/generic/280 | 13 ++++++++++++-
 tests/generic/390 |  8 +++++++-
 tests/generic/459 |  2 ++
 tests/generic/491 |  9 +++++++++
 tests/xfs/011     |  3 ++-
 tests/xfs/119     | 10 ++++++++++
 tests/xfs/297     | 11 +++++++++++
 tests/xfs/318     |  6 ++++--
 tests/xfs/325     |  6 ++++--
 tests/xfs/422     | 35 ++++++++++++++++++++++++++++++++---
 tests/xfs/438     |  4 +++-
 tests/xfs/517     | 27 ++++++++++++++++++++++++---
 14 files changed, 133 insertions(+), 18 deletions(-)