mbox series

[v2,0/4] overlayfs: Test data-only upperdirs and fs-verity

Message ID cover.1688979643.git.alexl@redhat.com (mailing list archive)
Headers show
Series overlayfs: Test data-only upperdirs and fs-verity | expand

Message

Alexander Larsson July 10, 2023, 9:07 a.m. UTC
From: Alexander Larsson <alexl@redhat.com>

This adds support for testing the new data-only upperdir feature which is
currently in master and will be in 6.5-rc1. It also adds tests for the
fs-verity validation feature which is queued in overlayfs-next for 6.6.

All new tests check for the required features before running, so
having it in early will be nice for testers of linux-next.

Changes since v1:
 * Consistently use $fstyp and $scratch_mnt in _require_scratch_verity
   (Pointed out by Eric Biggers)
 * Added Signed-off-by to patches from Amir

Alexander Larsson (1):
  overlay: Add test coverage for fs-verity support

Amir Goldstein (3):
  overlay: add helper for mounting rdonly overlay
  overlay/060: add test cases of follow to lowerdata
  overlay: Add test for follow of lowerdata in data-only layers

 common/overlay        |  35 ++++-
 common/verity         |  16 ++-
 tests/overlay/060     |  43 +++++-
 tests/overlay/060.out |  18 +++
 tests/overlay/079     | 325 +++++++++++++++++++++++++++++++++++++++++
 tests/overlay/079.out |  42 ++++++
 tests/overlay/080     | 326 ++++++++++++++++++++++++++++++++++++++++++
 tests/overlay/080.out |   7 +
 8 files changed, 800 insertions(+), 12 deletions(-)
 create mode 100755 tests/overlay/079
 create mode 100644 tests/overlay/079.out
 create mode 100755 tests/overlay/080
 create mode 100644 tests/overlay/080.out

Comments

Zorro Lang July 13, 2023, 3:34 p.m. UTC | #1
On Mon, Jul 10, 2023 at 11:07:09AM +0200, alexl@redhat.com wrote:
> From: Alexander Larsson <alexl@redhat.com>
> 
> This adds support for testing the new data-only upperdir feature which is
> currently in master and will be in 6.5-rc1. It also adds tests for the
> fs-verity validation feature which is queued in overlayfs-next for 6.6.
> 
> All new tests check for the required features before running, so
> having it in early will be nice for testers of linux-next.
> 
> Changes since v1:
>  * Consistently use $fstyp and $scratch_mnt in _require_scratch_verity
>    (Pointed out by Eric Biggers)
>  * Added Signed-off-by to patches from Amir
> 
> Alexander Larsson (1):
>   overlay: Add test coverage for fs-verity support
> 
> Amir Goldstein (3):
>   overlay: add helper for mounting rdonly overlay
>   overlay/060: add test cases of follow to lowerdata
>   overlay: Add test for follow of lowerdata in data-only layers

This patchset looks good to me, and I didn't regression from it. So if there's
not more review points from overlayfs side, I'll merge this patchset in next
fstests release.

Reviewed-by: Zorro Lang <zlang@redhat.com>

Thanks,
Zorro

> 
>  common/overlay        |  35 ++++-
>  common/verity         |  16 ++-
>  tests/overlay/060     |  43 +++++-
>  tests/overlay/060.out |  18 +++
>  tests/overlay/079     | 325 +++++++++++++++++++++++++++++++++++++++++
>  tests/overlay/079.out |  42 ++++++
>  tests/overlay/080     | 326 ++++++++++++++++++++++++++++++++++++++++++
>  tests/overlay/080.out |   7 +
>  8 files changed, 800 insertions(+), 12 deletions(-)
>  create mode 100755 tests/overlay/079
>  create mode 100644 tests/overlay/079.out
>  create mode 100755 tests/overlay/080
>  create mode 100644 tests/overlay/080.out
> 
> -- 
> 2.40.1
>
Amir Goldstein July 13, 2023, 4:15 p.m. UTC | #2
On Thu, Jul 13, 2023 at 6:35 PM Zorro Lang <zlang@redhat.com> wrote:
>
> On Mon, Jul 10, 2023 at 11:07:09AM +0200, alexl@redhat.com wrote:
> > From: Alexander Larsson <alexl@redhat.com>
> >
> > This adds support for testing the new data-only upperdir feature which is
> > currently in master and will be in 6.5-rc1. It also adds tests for the
> > fs-verity validation feature which is queued in overlayfs-next for 6.6.
> >
> > All new tests check for the required features before running, so
> > having it in early will be nice for testers of linux-next.
> >
> > Changes since v1:
> >  * Consistently use $fstyp and $scratch_mnt in _require_scratch_verity
> >    (Pointed out by Eric Biggers)
> >  * Added Signed-off-by to patches from Amir
> >
> > Alexander Larsson (1):
> >   overlay: Add test coverage for fs-verity support
> >
> > Amir Goldstein (3):
> >   overlay: add helper for mounting rdonly overlay
> >   overlay/060: add test cases of follow to lowerdata
> >   overlay: Add test for follow of lowerdata in data-only layers
>
> This patchset looks good to me, and I didn't regression from it. So if there's
> not more review points from overlayfs side, I'll merge this patchset in next
> fstests release.
>

That would be great.

Thanks,
Amir.