mbox series

[0/4] btrfs: make test pass or skip them when using nodatacow

Message ID cover.1706810184.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: make test pass or skip them when using nodatacow | expand

Message

Filipe Manana Feb. 1, 2024, 6:03 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Several test btrfs test cases fail when using "-o nodatacow" in MOUNT_OPTIONS.
So fix that by either adapting the tests to pass or skip them if there's no
way for them to succeed in nodatacow mode.

Filipe Manana (4):
  btrfs: require no nodatacow for tests that exercise compression
  btrfs/173: make the test work when mounting with nodatacow
  btrfs/299: skip test if we were mounted with nodatacow
  btrfs: require no nodatacow for tests that exercise read repair

 tests/btrfs/024 | 1 +
 tests/btrfs/048 | 1 +
 tests/btrfs/059 | 1 +
 tests/btrfs/138 | 1 +
 tests/btrfs/140 | 3 ++-
 tests/btrfs/141 | 2 ++
 tests/btrfs/157 | 2 ++
 tests/btrfs/158 | 2 ++
 tests/btrfs/173 | 5 +++++
 tests/btrfs/215 | 2 ++
 tests/btrfs/234 | 1 +
 tests/btrfs/265 | 2 ++
 tests/btrfs/266 | 2 ++
 tests/btrfs/267 | 2 ++
 tests/btrfs/268 | 2 ++
 tests/btrfs/269 | 2 ++
 tests/btrfs/281 | 1 +
 tests/btrfs/289 | 2 ++
 tests/btrfs/299 | 3 +++
 19 files changed, 36 insertions(+), 1 deletion(-)

Comments

David Disseldorp Feb. 5, 2024, 12:29 p.m. UTC | #1
On Thu,  1 Feb 2024 18:03:46 +0000, fdmanana@kernel.org wrote:

> From: Filipe Manana <fdmanana@suse.com>
> 
> Several test btrfs test cases fail when using "-o nodatacow" in MOUNT_OPTIONS.
> So fix that by either adapting the tests to pass or skip them if there's no
> way for them to succeed in nodatacow mode.
> 
> Filipe Manana (4):
>   btrfs: require no nodatacow for tests that exercise compression
>   btrfs/173: make the test work when mounting with nodatacow
>   btrfs/299: skip test if we were mounted with nodatacow
>   btrfs: require no nodatacow for tests that exercise read repair

The double negative hurts my eyes, but these all look fine to me (one
minor nit in 2/4).

Reviewed-by: David Disseldorp <ddiss@suse.de>