From patchwork Thu Dec 11 22:11:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishal Verma X-Patchwork-Id: 5477991 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AE011BEEA8 for ; Thu, 11 Dec 2014 22:12:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0204201D3 for ; Thu, 11 Dec 2014 22:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F25201C8 for ; Thu, 11 Dec 2014 22:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933031AbaLKWMc (ORCPT ); Thu, 11 Dec 2014 17:12:32 -0500 Received: from mga01.intel.com ([192.55.52.88]:18845 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932909AbaLKWMc (ORCPT ); Thu, 11 Dec 2014 17:12:32 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 11 Dec 2014 14:11:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,560,1413270000"; d="scan'208";a="646316358" Received: from vverma7-desk1.lm.intel.com (HELO omniknight-lm-intel-com.lm.intel.com) ([10.232.112.244]) by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2014 14:11:26 -0800 From: Vishal Verma To: fstests@vger.kernel.org Subject: [PATCH v2] ext4: the _require checks for bigalloc need a larger fs size Date: Thu, 11 Dec 2014 15:11:20 -0700 Message-Id: <1418335880-27252-1-git-send-email-vishal.l.verma@linux.intel.com> X-Mailer: git-send-email 2.1.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc create a 200k fs. DAX (as XIP before it) relies on a fs block size == system page size; ie 4k for us. With a 200k fs size limit, mkfs refuses to create a filesystem with a 4k block size, so the check fails, but for a bogus reason. Increasing the fs size to 512m allows mkfs to create a filesystem with 4k block size, so the test passes. Signed-off-by: Vishal Verma Signed-off-by: Matthew Wilcox Reviewed-by: Theodore Ts'o --- v1->v2 Update commit log with feedback from Matthew. common/rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/rc b/common/rc index d5e3aff..615a446 100644 --- a/common/rc +++ b/common/rc @@ -1314,7 +1314,7 @@ _require_xfs_crc() # _require_ext4_mkfs_bigalloc() { - $MKFS_EXT4_PROG -F -O bigalloc -n $SCRATCH_DEV 200k >/dev/null 2>&1 \ + $MKFS_EXT4_PROG -F -O bigalloc -n $SCRATCH_DEV 512m >/dev/null 2>&1 \ || _notrun "mkfs.ext4 doesn't have bigalloc feature" } @@ -1322,7 +1322,7 @@ _require_ext4_mkfs_bigalloc() # _require_ext4_bigalloc() { - $MKFS_EXT4_PROG -F -O bigalloc $SCRATCH_DEV 200k >/dev/null 2>&1 + $MKFS_EXT4_PROG -F -O bigalloc $SCRATCH_DEV 512m >/dev/null 2>&1 _scratch_mount >/dev/null 2>&1 \ || _notrun "Ext4 kernel doesn't support bigalloc feature" umount $SCRATCH_MNT