From patchwork Fri May 29 03:52:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Chinner X-Patchwork-Id: 6504231 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CFC379F38D for ; Fri, 29 May 2015 03:52:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 424D62051C for ; Fri, 29 May 2015 03:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D609204AD for ; Fri, 29 May 2015 03:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754642AbbE2Dwx (ORCPT ); Thu, 28 May 2015 23:52:53 -0400 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:60542 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754565AbbE2Dwx (ORCPT ); Thu, 28 May 2015 23:52:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CkDwCE4WdVPGuALHlcgxCBMoZMpTkGmyBNAQEBAQEBBwEBAQFAAT9BBYQKLzsYagMHLYgsoiG0H4YZiWKFAgWGa4t2mCaKP4EEZgELARKCJCwxgQSBQwEBAQ Received: from ppp121-44-128-107.lns20.syd7.internode.on.net (HELO dastard) ([121.44.128.107]) by ipmail04.adl6.internode.on.net with ESMTP; 29 May 2015 13:22:51 +0930 Received: from disappointment.disaster.area ([192.168.1.110] helo=disappointment) by dastard with esmtp (Exim 4.80) (envelope-from ) id 1YyBLm-000735-MJ for fstests@vger.kernel.org; Fri, 29 May 2015 13:52:50 +1000 Received: from dave by disappointment with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1YyBLm-0004lF-LQ for fstests@vger.kernel.org; Fri, 29 May 2015 13:52:50 +1000 From: Dave Chinner To: fstests@vger.kernel.org Subject: [PATCH] xfs: tests extent size hint size overflows Date: Fri, 29 May 2015 13:52:50 +1000 Message-Id: <1432871570-18267-1-git-send-email-david@fromorbit.com> X-Mailer: git-send-email 2.0.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dave Chinner In certain cases, the extent size hints can cause maximum extent size overflows resulting in extent tree corruptions. This test exercises the original reproducer, and another corner case demonstrated to expose problems on 1k block size filesystems. Signed-off-by: Dave Chinner Reviewed-by: Eryu Guan --- Version 2: - TESTDIR->TEST_DIR - append output to $seqres.full --- tests/xfs/074 | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/074.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 96 insertions(+) create mode 100755 tests/xfs/074 create mode 100644 tests/xfs/074.out diff --git a/tests/xfs/074 b/tests/xfs/074 new file mode 100755 index 0000000..a571a34 --- /dev/null +++ b/tests/xfs/074 @@ -0,0 +1,93 @@ +#! /bin/bash +# FS QA Test 074-extsz-hints-vs-maxextlen +# +# Check some extent size hint boundary conditions that can result in +# MAXEXTLEN overflows. +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +_cleanup() +{ + cd / + _destroy_loop_device $LOOP_DEV + rm -f $tmp.* $LOOP_FILE +} + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs xfs +_supported_os Linux + +rm -f $seqres.full + +_require_test +_require_xfs_io_command "falloc" + +# we use loop devices for this so that we can create large files for prealloc +# without having to care about the underlying device size. +_require_loop + +LOOP_FILE=$TEST_DIR/$seq.img +LOOP_MNT=$TEST_DIR/$seq.mnt +mkdir -p $LOOP_MNT +$XFS_IO_PROG -ft -c "truncate 1t" $LOOP_FILE >> $seqres.full +LOOP_DEV=`_create_loop_device $LOOP_FILE` + +_mkfs_dev -d size=40051712b,agcount=4 -l size=32m $LOOP_DEV +_mount $LOOP_DEV $LOOP_MNT + +# Corrupt the BMBT by creating extents larger than MAXEXTLEN +$XFS_IO_PROG -ft \ + -c "extsize 16m" \ + -c "falloc 0 30g" \ + $LOOP_MNT/foo >> $seqres.full + +umount $LOOP_MNT +_check_xfs_filesystem $LOOP_DEV none none + +_mkfs_dev -f -l size=32m $LOOP_DEV +_mount $LOOP_DEV $LOOP_MNT + +# check we trim both ends of the extent approproiately; this will fail +# on 1k block size filesystems without the correct fixes in place. +$XFS_IO_PROG -ft \ + -c "extsize 1g" \ + -c "falloc 1023m 2g" \ + $LOOP_MNT/foo >> $seqres.full + +umount $LOOP_MNT +_check_xfs_filesystem $LOOP_DEV none none + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/xfs/074.out b/tests/xfs/074.out new file mode 100644 index 0000000..380f065 --- /dev/null +++ b/tests/xfs/074.out @@ -0,0 +1,2 @@ +QA output created by 074 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index 848a1bd..c211fc1 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -71,6 +71,7 @@ 071 rw auto 072 rw auto prealloc quick 073 copy auto +074 quick auto prealloc rw 078 growfs auto quick 080 rw ioctl 081 deprecated # log logprint quota