diff mbox

fstest: btrfs: update 048.out inline with ui changes

Message ID 1458814272-5783-1-git-send-email-anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Anand Jain March 24, 2016, 10:11 a.m. UTC
To be inline with progs changes
  28831d54895443e5fc795392f23ce3a8b122cb71
  btrfs-progs: cmd property: switch to common error message wrapper
update 048.out

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 tests/btrfs/048.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Filipe Manana March 24, 2016, 11:10 a.m. UTC | #1
On Thu, Mar 24, 2016 at 10:11 AM, Anand Jain <anand.jain@oracle.com> wrote:
> To be inline with progs changes
>   28831d54895443e5fc795392f23ce3a8b122cb71
>   btrfs-progs: cmd property: switch to common error message wrapper
> update 048.out
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  tests/btrfs/048.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
> index 0b20d0b5976c..1d3ccef8e870 100644
> --- a/tests/btrfs/048.out
> +++ b/tests/btrfs/048.out
> @@ -9,7 +9,7 @@ label=foobar
>  ***
>  label=
>  ***
> -ERROR: object is not compatible with property
> +ERROR: object is not compatible with property: label

This now makes the test fail with older versions of btrfs-progs...

Same observation as before, update your git branch and read the mailing list:

https://git.kernel.org/cgit/fs/xfs/xfstests-dev.git/commit/?id=232593dea51c53f3251f9b41cd89e9dba20f0159
https://git.kernel.org/cgit/fs/xfs/xfstests-dev.git/commit/?id=2dd2cea4b51810bbb4090ebdc20ee799e63e5fd8

>  ***
>
>  Testing subvolume ro property
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eryu Guan March 24, 2016, 11:13 a.m. UTC | #2
On Thu, Mar 24, 2016 at 06:11:12PM +0800, Anand Jain wrote:
> To be inline with progs changes
>   28831d54895443e5fc795392f23ce3a8b122cb71
>   btrfs-progs: cmd property: switch to common error message wrapper
> update 048.out
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  tests/btrfs/048.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
> index 0b20d0b5976c..1d3ccef8e870 100644
> --- a/tests/btrfs/048.out
> +++ b/tests/btrfs/048.out
> @@ -9,7 +9,7 @@ label=foobar
>  ***
>  label=
>  ***
> -ERROR: object is not compatible with property
> +ERROR: object is not compatible with property: label

This fails test with old btrfs-progs. I think a filter can be added to
btrfs/048 to filter out the ": label" part, so that test passes with
both old and new btrfs-progs.

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Anand Jain March 24, 2016, 11:16 a.m. UTC | #3
On 03/24/2016 07:13 PM, Eryu Guan wrote:
> On Thu, Mar 24, 2016 at 06:11:12PM +0800, Anand Jain wrote:
>> To be inline with progs changes
>>    28831d54895443e5fc795392f23ce3a8b122cb71
>>    btrfs-progs: cmd property: switch to common error message wrapper
>> update 048.out
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>>   tests/btrfs/048.out | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
>> index 0b20d0b5976c..1d3ccef8e870 100644
>> --- a/tests/btrfs/048.out
>> +++ b/tests/btrfs/048.out
>> @@ -9,7 +9,7 @@ label=foobar
>>   ***
>>   label=
>>   ***
>> -ERROR: object is not compatible with property
>> +ERROR: object is not compatible with property: label
>
> This fails test with old btrfs-progs. I think a filter can be added to
> btrfs/048 to filter out the ": label" part, so that test passes with
> both old and new btrfs-progs.

  Thanks.  Yep. I shall do that.



--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
index 0b20d0b5976c..1d3ccef8e870 100644
--- a/tests/btrfs/048.out
+++ b/tests/btrfs/048.out
@@ -9,7 +9,7 @@  label=foobar
 ***
 label=
 ***
-ERROR: object is not compatible with property
+ERROR: object is not compatible with property: label
 ***
 
 Testing subvolume ro property