diff mbox

common/populate: remove unnecessary devices directory creation

Message ID 1460942807-19296-1-git-send-email-wangxg.fnst@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xiaoguang Wang April 18, 2016, 1:26 a.m. UTC
_scratch_ext4_populate and _scratch_xfs_populate try to create
devices directory in xfstests/, so if we run xfs/083 or ext4/006
twice, it'll fail, fix this issue.

Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
---
 common/populate | 2 --
 1 file changed, 2 deletions(-)

Comments

Darrick J. Wong April 25, 2016, 8:50 p.m. UTC | #1
On Mon, Apr 18, 2016 at 09:26:47AM +0800, Xiaoguang Wang wrote:
> _scratch_ext4_populate and _scratch_xfs_populate try to create
> devices directory in xfstests/, so if we run xfs/083 or ext4/006
> twice, it'll fail, fix this issue.

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> 
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
> ---
>  common/populate | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/common/populate b/common/populate
> index d166c24..aa6ed79 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -141,7 +141,6 @@ _scratch_xfs_populate() {
>  
>  	# Char & block
>  	echo "+ special"
> -	mkdir devices
>  	mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1
>  	mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1
>  
> @@ -241,7 +240,6 @@ _scratch_ext4_populate() {
>  
>  	# Char & block
>  	echo "+ special"
> -	mkdir devices
>  	mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1
>  	mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1
>  
> -- 
> 1.8.3.1
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/populate b/common/populate
index d166c24..aa6ed79 100644
--- a/common/populate
+++ b/common/populate
@@ -141,7 +141,6 @@  _scratch_xfs_populate() {
 
 	# Char & block
 	echo "+ special"
-	mkdir devices
 	mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1
 	mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1
 
@@ -241,7 +240,6 @@  _scratch_ext4_populate() {
 
 	# Char & block
 	echo "+ special"
-	mkdir devices
 	mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1
 	mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1