From patchwork Wed Jun 22 11:43:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 9192505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 147FC6075A for ; Wed, 22 Jun 2016 11:43:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 052CE28364 for ; Wed, 22 Jun 2016 11:43:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDFE7283F9; Wed, 22 Jun 2016 11:43:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EE7B283FE for ; Wed, 22 Jun 2016 11:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbcFVLnq (ORCPT ); Wed, 22 Jun 2016 07:43:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbcFVLno (ORCPT ); Wed, 22 Jun 2016 07:43:44 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E69078225 for ; Wed, 22 Jun 2016 11:43:39 +0000 (UTC) Received: from localhost (dhcp12-144.nay.redhat.com [10.66.12.144] (may be forged)) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5MBhc4T020856; Wed, 22 Jun 2016 07:43:38 -0400 From: Eryu Guan To: fstests@vger.kernel.org Cc: Eryu Guan Subject: [PATCH v3 2/2] ext4/271: _notrun if there are journal related mount options Date: Wed, 22 Jun 2016 19:43:31 +0800 Message-Id: <1466595811-23822-2-git-send-email-eguan@redhat.com> In-Reply-To: <1466595811-23822-1-git-send-email-eguan@redhat.com> References: <1466595811-23822-1-git-send-email-eguan@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 22 Jun 2016 11:43:39 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ext4/271 runs in no journal mode (-onoload), so running test with journal related mount options makes no sense, and test fails after kernel commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal"), journal related mount options are not allowed in no journal mode. So _notrun if there're journal related mount options. Signed-off-by: Eryu Guan --- v3: - rename _require_no_mount_opts to _exclude_mount_option v2: - update comments in the code - rebase on top of current master tests/ext4/271 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/ext4/271 b/tests/ext4/271 index d68c271..c04fd4a 100755 --- a/tests/ext4/271 +++ b/tests/ext4/271 @@ -39,6 +39,12 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 _supported_fs ext4 _supported_os Linux _require_scratch +# this test needs no journal to be loaded, skip on journal related mount +# options, otherwise mount would fail with "-o noload" mount option +_exclude_mount_option "data=" +_exclude_mount_option "commit=" +_exclude_mount_option "journal_checksum" +_exclude_mount_option "journal_async_commit" rm -f $seqres.full _scratch_mkfs_sized $((128 * 1024 * 1024)) >> $seqres.full 2>&1