From patchwork Tue Aug 30 07:39:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Savkov X-Patchwork-Id: 9304961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 718E0601C0 for ; Tue, 30 Aug 2016 07:39:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6252328AE1 for ; Tue, 30 Aug 2016 07:39:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 571AF28AFE; Tue, 30 Aug 2016 07:39:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9115E28AE1 for ; Tue, 30 Aug 2016 07:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754077AbcH3HjM (ORCPT ); Tue, 30 Aug 2016 03:39:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbcH3HjL (ORCPT ); Tue, 30 Aug 2016 03:39:11 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3091A077C; Tue, 30 Aug 2016 07:39:10 +0000 (UTC) Received: from shodan.usersys.redhat.com (dhcp-1-150.brq.redhat.com [10.34.1.150]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7U7d9rq015786; Tue, 30 Aug 2016 03:39:10 -0400 Received: by shodan.usersys.redhat.com (Postfix, from userid 1000) id 3DBD52C010F; Tue, 30 Aug 2016 09:39:09 +0200 (CEST) From: Artem Savkov To: Eryu Guan Cc: fstests@vger.kernel.org, Dave Chinner , Artem Savkov Subject: [PATCH v4] Add a test for listxattr syscall with different buffer sizes. Date: Tue, 30 Aug 2016 09:39:07 +0200 Message-Id: <1472542747-28307-1-git-send-email-asavkov@redhat.com> In-Reply-To: <20160830043516.GK27776@eguan.usersys.redhat.com> References: <20160830043516.GK27776@eguan.usersys.redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 30 Aug 2016 07:39:10 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add generic/375 test that calls listxattr syscall with different buffer size arguments checking if it fails properly. Signed-off-by: Artem Savkov --- .gitignore | 1 + src/Makefile | 2 +- src/listxattr.c | 73 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/375 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/375.out | 11 +++++++ tests/generic/group | 1 + 6 files changed, 174 insertions(+), 1 deletion(-) create mode 100644 src/listxattr.c create mode 100755 tests/generic/375 create mode 100644 tests/generic/375.out diff --git a/.gitignore b/.gitignore index d84f385..915d2d8 100644 --- a/.gitignore +++ b/.gitignore @@ -66,6 +66,7 @@ /src/holes /src/holetest /src/itrash +/src/listxattr /src/locktest /src/loggen /src/looptest diff --git a/src/Makefile b/src/Makefile index 57b0df1..dd51216 100644 --- a/src/Makefile +++ b/src/Makefile @@ -21,7 +21,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ stale_handle pwrite_mmap_blocked t_dir_offset2 seek_sanity_test \ seek_copy_test t_readdir_1 t_readdir_2 fsync-tester nsexec cloner \ renameat2 t_getcwd e4compact test-nextquota punch-alternating \ - attr-list-by-handle-cursor-test + attr-list-by-handle-cursor-test listxattr SUBDIRS = diff --git a/src/listxattr.c b/src/listxattr.c new file mode 100644 index 0000000..cd46637 --- /dev/null +++ b/src/listxattr.c @@ -0,0 +1,73 @@ +/* + * Copyright (c) 2016 Red Hat, Inc. All Rights Reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation, either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it would be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see . + */ + +#include +#include +#include +#include +#include +#include +#include + +int main(int argc, char **argv) +{ + int ret; + size_t bufsize = 0; + char *buf = NULL; + + if (argc < 2) { + fprintf(stderr, "usage: %s [bufsize]\n", argv[0]); + return 1; + }; + + if (argc > 2) { + bufsize = strtoul(argv[2], NULL, 10); + if (bufsize == -1) { + perror("buffsize"); + return 1; + } + } + + if (bufsize == 0) { + bufsize = listxattr(argv[1], NULL, 0); + if (bufsize == -1) { + perror("listxattr"); + return 1; + } + } + + buf = malloc(bufsize); + if (buf == NULL) { + perror("buf alloc"); + return 1; + } + + ret = listxattr(argv[1], buf, bufsize); + if (ret < 0) { + perror("listxattr"); + } else { + char *l; + for (l = buf; l != (buf + bufsize) && *l != '\0'; + l = strchr(l, '\0') + 1) { + printf("xattr: %s\n", l); + } + } + + free(buf); + + return 0; +} diff --git a/tests/generic/375 b/tests/generic/375 new file mode 100755 index 0000000..6e85f46 --- /dev/null +++ b/tests/generic/375 @@ -0,0 +1,87 @@ +#! /bin/bash +# FSQA Test No. 375 +# +# Test listxattr syscall behaviour with different buffer sizes. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, see . +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/attr + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch +_require_attrs +_require_test_program "listxattr" + +listxattr="$here/src/listxattr" + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount + +# Create a testfile with three xattrs such that the sum of namelengths of the +# first two is bigger than the namelength of the third. This is needed for +# the 5th testcase that tests one of the cornercases. +testfile=${SCRATCH_MNT}/testfile +touch $testfile +$SETFATTR_PROG -n user.foo -v bar $testfile +$SETFATTR_PROG -n user.ping -v pong $testfile +$SETFATTR_PROG -n user.hello -v there $testfile + +# 1. Call listxattr without buffer length argument. This should succeed. +$listxattr $testfile | sort + +# 2. Calling listxattr on nonexistant file should fail with -ENOENT. +$listxattr "" + +# 3. Calling listxattr with buffersize not suffecient for even one xattr +# should fail with -ERANGE. +$listxattr $testfile 1 + +# 4. Calling listxattr with buffersize suffecient for one xattr, but not +# sufficient for the whole list should still fail with -ERANGE. +$listxattr $testfile 9 + +# 5. Calling listxattr with buffersize suffecient for the last xattr, but not +# sufficient for the sum of first two. Should fail with -ERANGE. +$listxattr $testfile 11 + +# 6. Calling listxattr with buffersize bigger than needed should succeed. +$listxattr $testfile 500 | sort + +status=0 +exit diff --git a/tests/generic/375.out b/tests/generic/375.out new file mode 100644 index 0000000..820f40c --- /dev/null +++ b/tests/generic/375.out @@ -0,0 +1,11 @@ +QA output created by 375 +xattr: user.foo +xattr: user.hello +xattr: user.ping +listxattr: No such file or directory +listxattr: Numerical result out of range +listxattr: Numerical result out of range +listxattr: Numerical result out of range +xattr: user.foo +xattr: user.hello +xattr: user.ping diff --git a/tests/generic/group b/tests/generic/group index ef38c35..f5aea8d 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -377,3 +377,4 @@ 372 auto quick clone 373 auto quick clone 374 auto quick clone dedupe +375 attr auto quick metadata