From patchwork Wed Oct 19 11:50:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Gruenbacher X-Patchwork-Id: 9384071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3D019608A7 for ; Wed, 19 Oct 2016 14:18:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EC6829A39 for ; Wed, 19 Oct 2016 14:18:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2376929A3B; Wed, 19 Oct 2016 14:18:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFFC729A3C for ; Wed, 19 Oct 2016 14:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938900AbcJSOSW (ORCPT ); Wed, 19 Oct 2016 10:18:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8382 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938778AbcJSOSV (ORCPT ); Wed, 19 Oct 2016 10:18:21 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10FF161A1B for ; Wed, 19 Oct 2016 11:50:17 +0000 (UTC) Received: from nux.redhat.com (vpn1-6-241.ams2.redhat.com [10.36.6.241]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9JBoFuP028767; Wed, 19 Oct 2016 07:50:15 -0400 From: Andreas Gruenbacher To: fstests@vger.kernel.org Cc: Andreas Gruenbacher Subject: [PATCH] generic: Check linking O_TMPFILE into namespace with POSIX ACLs Date: Wed, 19 Oct 2016 13:50:14 +0200 Message-Id: <1476877814-29310-1-git-send-email-agruenba@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 19 Oct 2016 11:50:17 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When an O_TMPFILE file is linked into a directory with a POSIX default ACL, the file should inherit the default ACL and the umask needs to be ignored. This goes together with generic/004, which tests O_TMPFILE files without POSIX ACLs. Signed-off-by: Andreas Gruenbacher --- tests/generic/389 | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/389.out | 6 +++++ tests/generic/group | 1 + 3 files changed, 78 insertions(+) create mode 100755 tests/generic/389 create mode 100644 tests/generic/389.out diff --git a/tests/generic/389 b/tests/generic/389 new file mode 100755 index 0000000..23ca6d2 --- /dev/null +++ b/tests/generic/389 @@ -0,0 +1,71 @@ +#! /bin/bash +# FS QA Test 389 +# +# Test if O_TMPFILE files inherit POSIX Default ACLs when they are linked into +# the namespace (also see tests/generic/004). +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f ${testfile} +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/attr +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_test +_require_xfs_io_command "flink" +_require_acls + +# remove previous $seqres.full before test +rm -f $seqres.full + +testfile="${TEST_DIR}/d/tst-tmpfile-flink" + +umask 022 +mkdir -p ${TEST_DIR}/d +setfacl -d -m u::rwx,g::rwx,o::rx ${TEST_DIR}/d +$XFS_IO_PROG -T -m 0666 \ + -c "pwrite 0 4096" \ + -c "pread 0 4096" \ + -c "flink ${testfile}" \ + ${TEST_DIR}/d | _filter_xfs_io +stat -c '%a' ${testfile} +rm -rf ${TEST_DIR}/d + +# success, all done +status=0 +exit diff --git a/tests/generic/389.out b/tests/generic/389.out new file mode 100644 index 0000000..4d11ac7 --- /dev/null +++ b/tests/generic/389.out @@ -0,0 +1,6 @@ +QA output created by 389 +wrote 4096/4096 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +read 4096/4096 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +664 diff --git a/tests/generic/group b/tests/generic/group index fc32cfd..2656ff2 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -391,3 +391,4 @@ 386 auto quick quota 387 auto clone 388 auto log metadata +389 auto quick