From patchwork Tue Dec 20 13:17:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9481553 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E03DA606DB for ; Tue, 20 Dec 2016 13:18:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2BDB2841C for ; Tue, 20 Dec 2016 13:18:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7A3C2848D; Tue, 20 Dec 2016 13:18:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6353A2841C for ; Tue, 20 Dec 2016 13:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757999AbcLTNSM (ORCPT ); Tue, 20 Dec 2016 08:18:12 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35609 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757981AbcLTNSL (ORCPT ); Tue, 20 Dec 2016 08:18:11 -0500 Received: by mail-wm0-f68.google.com with SMTP id a20so24365987wme.2 for ; Tue, 20 Dec 2016 05:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RrfGfLTvGhX2mYUd6hsQXpbWBJm1AygK5vyM2TGB4wQ=; b=PmRqPi0mIOcHh2UzAGBSZjGVsmhUc37uk2t5brGdXjBvgydWD33ZJ0rrIRSUdqwuct pN/t0ParSEFppH0oEGxpQlIHPqPQ0h4Y+uOKOnSo9oluoCr+xV51yf+08Tz8klkD38p9 qy7TSqjDDBFKcEjH4hvqsa8/rKmUzPZRxzuMxCbHpzLsdRoF6K+d2GdQxU9eWu7mwErJ GecQx2KBnBMtYAksI+5sj9ZcSoyjIiIDy07s1AYQSWOEOSCCxGft5ihiS8PIGd4ZBOQt PbPQUPsR5434yDZZIg+kLPNTuDFrGp36QNcVDNT9sYt8WIJDg6ydiRwjBShl2pi35kRn VxYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RrfGfLTvGhX2mYUd6hsQXpbWBJm1AygK5vyM2TGB4wQ=; b=qfURB3LtgUAKJWyEuKEyNTh9iNtq5tei2LcOePXvHdwlAtES7KAoJFQQk53+ixzk1T w5iOBXtfJqtJJGMlnnY+51FolW7wH/ufTJretVYy/XDxQh68yMz6jTnfXZ5NDaXYsNBK UZ8l+GIu0QL0WU+bdO0HfMO1nJ+4kYWvrTQ7b4IFmvsy54610XtnMrMfwQg64C20gYvz 7k4482wdETKt2COPY2OJakPmNimZ1fRxbYaXCZ6flBwBycjilYvUl9OxZCHA5VZaAHpj PfVzkRvXdEr9Fy84v4O9/VwocRt/+uAWjmFEvTqNTSlL0pgZEHOzdD099PIfnETW7rIW xaGQ== X-Gm-Message-State: AIkVDXKZHinHce8nrfGqGWiQcs1oWIDAEBLSp2DXstICcZ1iv5UW6/3j6gkSE7hQPSs0EQ== X-Received: by 10.28.136.198 with SMTP id k189mr1887759wmd.24.1482239889636; Tue, 20 Dec 2016 05:18:09 -0800 (PST) Received: from amir-VirtualBox.ctera.local (bzq-82-81-193-202.cablep.bezeqint.net. [82.81.193.202]) by smtp.gmail.com with ESMTPSA id d64sm22041525wmh.3.2016.12.20.05.18.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Dec 2016 05:18:09 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Miklos Szeredi , fstests@vger.kernel.org Subject: [PATCH v2 3/3] generic/396: test correct d_type values Date: Tue, 20 Dec 2016 15:17:35 +0200 Message-Id: <1482239855-791-4-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482239855-791-1-git-send-email-amir73il@gmail.com> References: <1482239855-791-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Verify correct d_type values of dir entries. This test does NOT require that file system support the filetype feature. It verifies that either all file types are reported as DT_UNKNOWN or that all file types are reported correctly. For fs for which we know how to test the filetype feature (xfs|ext*) verify getting DT_UNKNOWN IFF feature is disabled. Verify special dir entries . and .. are always reported as DT_DIR. Signed-off-by: Amir Goldstein --- tests/generic/396 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/396.out | 9 ++++++ tests/generic/group | 1 + 3 files changed, 97 insertions(+) create mode 100755 tests/generic/396 create mode 100644 tests/generic/396.out diff --git a/tests/generic/396 b/tests/generic/396 new file mode 100755 index 0000000..fbd2e79 --- /dev/null +++ b/tests/generic/396 @@ -0,0 +1,87 @@ +#! /bin/bash +# FSQA Test No. 396 +# +# Test filetype feature +# +# This test does NOT require that file system support the d_type feature. +# It verifies that either all file types are reported as DT_UNKNOWN +# or all file types are reported correctly. +# +# For fs for which we know how to test the filetype feature (xfs|ext*) +# verify getting DT_UNKNOWN IFF feature is disabled. +# +# Verify special dir entries . and .. are always reported as DT_DIR. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2016 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 + +_scratch_mount + +# Create our test files. +testdir=$SCRATCH_MNT/find-by-type +mkdir -p $testdir +mkdir $testdir/d +touch $testdir/f +ln -s $testdir/f $testdir/l +mknod $testdir/c c 1 1 +mknod $testdir/b b 1 1 +mknod $testdir/p p + +# Test d_type DT_DIR for . and .. +# this should be correct on all fs regardless of filetype feature +src/t_dir_type $testdir d | grep -F '.' | sort + +# Test that either all file type are unknown or all are valid +if _supports_filetype $testdir; then + # print real file types + src/t_dir_type $testdir | grep -vF '.' | sort +else + # list unknown files and print filename as fake file type + src/t_dir_type $testdir u | awk '{ print $1, $1 }' | sort +fi + +status=0 +exit diff --git a/tests/generic/396.out b/tests/generic/396.out new file mode 100644 index 0000000..de11c24 --- /dev/null +++ b/tests/generic/396.out @@ -0,0 +1,9 @@ +QA output created by 396 +. d +.. d +b b +c c +d d +f f +l l +p p diff --git a/tests/generic/group b/tests/generic/group index 20b31ef..24c242f 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -397,3 +397,4 @@ 392 auto quick metadata 393 auto quick rw 394 auto quick +396 auto quick