diff mbox

xfstests-bld: remove redundant listing of GCE images

Message ID 1482343592-135031-6-git-send-email-ebiggers3@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Biggers Dec. 21, 2016, 6:06 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

When a GCE image is created, the same information about the new image
was being printed by both 'gcloud compute images create' and 'gcloud
compute images list'.  Fix this by removing the call to 'gcloud compute
images list'.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 kvm-xfstests/test-appliance/gce-create-image | 1 -
 1 file changed, 1 deletion(-)

Comments

Theodore Ts'o Dec. 22, 2016, 5:13 p.m. UTC | #1 
On Wed, Dec 21, 2016 at 10:06:32AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> When a GCE image is created, the same information about the new image
> was being printed by both 'gcloud compute images create' and 'gcloud
> compute images list'.  Fix this by removing the call to 'gcloud compute
> images list'.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

This was deliberate; the goal was to remind the image maintainer to
consider whether some of the older images should be GC'ed.

	 	      	     	   	  - Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/kvm-xfstests/test-appliance/gce-create-image b/kvm-xfstests/test-appliance/gce-create-image
index 005cc8e..830dd5b 100755
--- a/kvm-xfstests/test-appliance/gce-create-image
+++ b/kvm-xfstests/test-appliance/gce-create-image
@@ -138,4 +138,3 @@  gcloud compute --project "$GCE_PROJECT" -q images create "$ROOT_FS-$DATECODE" \
 	--family "$ROOT_FS"
 gcloud compute --project "$GCE_PROJECT" -q disks delete "$BLD_DISK" \
 	--zone "$GCE_ZONE" >& /dev/null &
-gcloud compute --project "$GCE_PROJECT" -q images list --filter="family=$ROOT_FS"