diff mbox

[2/3] xfs/299: don't chmod the underlying mountpoints prior to mounting

Message ID 148562509908.30594.7838088688242443797.stgit@birch.djwong.org (mailing list archive)
State New, archived
Headers show

Commit Message

Darrick J. Wong Jan. 28, 2017, 5:38 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

It's silly to make $SCRATCH_MNT world writable just prior to mounting
the scratch device; instead, do it after the mount.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/299 |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/xfs/299 b/tests/xfs/299
index d2670f8..997c5dc 100755
--- a/tests/xfs/299
+++ b/tests/xfs/299
@@ -203,9 +203,6 @@  cat $tmp.mkfs >>$seqres.full
 # keep the blocksize and data size for dd later
 . $tmp.mkfs
 
-# non-root users need to be able to write to this filesystem
-chmod 777 $SCRATCH_MNT
-
 cat >$tmp.projects <<EOF
 1:$SCRATCH_MNT
 EOF
@@ -220,6 +217,10 @@  projid_file="$tmp.projid"
 echo "*** user, group, and project"
 _qmount_option "uquota,gquota,pquota"
 _qmount
+
+# non-root users need to be able to write to this filesystem
+chmod 777 $SCRATCH_MNT
+
 _exercise p
 _exercise g
 _exercise u