From patchwork Tue Jun 27 09:03:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 9811065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A71760329 for ; Tue, 27 Jun 2017 09:04:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EC52284C7 for ; Tue, 27 Jun 2017 09:04:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 82B5F28524; Tue, 27 Jun 2017 09:04:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6888D284C7 for ; Tue, 27 Jun 2017 09:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbdF0JEc (ORCPT ); Tue, 27 Jun 2017 05:04:32 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:61808 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751819AbdF0JED (ORCPT ); Tue, 27 Jun 2017 05:04:03 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="20536807" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Jun 2017 17:04:01 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 79F05467021F for ; Tue, 27 Jun 2017 17:03:55 +0800 (CST) Received: from localhost.localdomain (10.167.220.81) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Jun 2017 17:03:54 +0800 From: Xiao Yang To: CC: Xiao Yang Subject: [PATCH] xfs: test a race between dio reads and mapped writes Date: Tue, 27 Jun 2017 17:03:52 +0800 Message-ID: <1498554232-20777-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.167.220.81] X-yoursite-MailScanner-ID: 79F05467021F.A8887 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This regression test reproduces a race between a direct I/O read and a mapped write to a hole in a file. If the race occurs, it will trigger a BUG_ON(). This XFS bug has been fixed by: 04197b3 (xfs: don't BUG() on mixed direct and mapped I/O) Signed-off-by: Xiao Yang --- tests/xfs/422 | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/422.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 89 insertions(+) create mode 100755 tests/xfs/422 create mode 100644 tests/xfs/422.out diff --git a/tests/xfs/422 b/tests/xfs/422 new file mode 100755 index 0000000..a57ffab --- /dev/null +++ b/tests/xfs/422 @@ -0,0 +1,86 @@ +#! /bin/bash +# FS QA Test No. 422 +# +# Regression test for commit: +# 04197b3 ("xfs: don't BUG() on mixed direct and mapped I/O) +# +# This case tests a race between a direct I/O read and a +# mapped write to a hole in a file. If the race occurs, +# it will trigger a BUG_ON(). +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Fujitsu. All Rights Reserved. +# Author: Xiao Yang +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -rf $tmp.* +} + +# get standard environment and checks +. ./common/rc + +# real QA test starts here +_supported_os Linux +_supported_fs xfs +_require_scratch +_disable_dmesg_check +_require_xfs_io_command "truncate" +_require_xfs_io_command "fpunch" + +rm -f $seqres.full + +# format and mount +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +filesz=$((65536 * 2)) + +# create a test file with a hole +$XFS_IO_PROG -f -c "truncate $((filesz * 2))" $SCRATCH_MNT/file >> $seqres.full + +# run a background dio read to a hole in a loop +while true; do + $XFS_IO_PROG -d -c "pread 0 $filesz" $SCRATCH_MNT/file > /dev/null 2>&1 +done & + +dread_pid=$! + +# run mapped write to the same hole as dio read +for i in `seq 0 999`; do + $XFS_IO_PROG -c "mmap 0 $filesz" -c "mwrite 0 $filesz" $SCRATCH_MNT/file \ + > /dev/null + $XFS_IO_PROG -c "fpunch 0 $filesz" $SCRATCH_MNT/file > /dev/null +done + +kill -9 $dread_pid > /dev/null 2>&1 +wait $dread_pid > /dev/null 2>&1 + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/xfs/422.out b/tests/xfs/422.out new file mode 100644 index 0000000..f70693f --- /dev/null +++ b/tests/xfs/422.out @@ -0,0 +1,2 @@ +QA output created by 422 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index 2a3b950..f43ffcf 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -419,3 +419,4 @@ 419 auto quick 420 auto quick clone dedupe 421 auto quick clone dedupe +422 auto quick dangerous