| Message ID | 1499802726-11045-6-git-send-email-amir73il@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 11, 2017 at 10:52:06PM +0300, Amir Goldstein wrote: > Expect EBUSY when trying to mount overlay when: > - Upper dir is in-use by another overlay mount > - Work dir is in-use by another overlay mount > > Signed-off-by: Amir Goldstein <amir73il@gmail.com> From patch 2/5, seems this behavior requires inode index feature to be enabled, and now test fails on old kernels for me. Is this expected? Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 12, 2017 at 1:47 PM, Eryu Guan <eguan@redhat.com> wrote: > On Tue, Jul 11, 2017 at 10:52:06PM +0300, Amir Goldstein wrote: >> Expect EBUSY when trying to mount overlay when: >> - Upper dir is in-use by another overlay mount >> - Work dir is in-use by another overlay mount >> >> Signed-off-by: Amir Goldstein <amir73il@gmail.com> > > From patch 2/5, seems this behavior requires inode index feature to be > enabled, and now test fails on old kernels for me. Is this expected? > From my cover letter: "The new test overlay/036 checks for new overlay mount behaviors related to exclusivity of upper and work dirs among overlay mounts. This test is expected to fail on upstream kernel, but for a good reason, because the mount configurations that it tests (sharing upper dir among two overlay mounts) are not wise at all." So the answer is yes, this is expected and also does not depend on index feature. I know this is a bit confusing, but inode index enforces that 2 *subsequent* overlay mount don't reuse the same upper/work dir with different lower/upper. The test that checks this behavior is overlay/037, still on my overlayfs-devel branch. overlay/036 verifies that 2 *concurrent* overlay mount don't reuse the same upper/work dir. The is enforced by overlayfs-next regardless on index feature. A setup like this will cause troubles in old kernel as well, but mount will not detect it. Amir. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 12, 2017 at 02:08:56PM +0300, Amir Goldstein wrote: > On Wed, Jul 12, 2017 at 1:47 PM, Eryu Guan <eguan@redhat.com> wrote: > > On Tue, Jul 11, 2017 at 10:52:06PM +0300, Amir Goldstein wrote: > >> Expect EBUSY when trying to mount overlay when: > >> - Upper dir is in-use by another overlay mount > >> - Work dir is in-use by another overlay mount > >> > >> Signed-off-by: Amir Goldstein <amir73il@gmail.com> > > > > From patch 2/5, seems this behavior requires inode index feature to be > > enabled, and now test fails on old kernels for me. Is this expected? > > > > From my cover letter: > "The new test overlay/036 checks for new overlay mount behaviors related > to exclusivity of upper and work dirs among overlay mounts. This test > is expected to fail on upstream kernel, but for a good reason, because > the mount configurations that it tests (sharing upper dir among two > overlay mounts) are not wise at all." > > So the answer is yes, this is expected and also does not depend > on index feature. I usually read the cover letter (I saved it in my 'review' mailbox along with patches to review), but somehow I forgot about it this time.. > > I know this is a bit confusing, but inode index enforces that 2 > *subsequent* overlay > mount don't reuse the same upper/work dir with different lower/upper. > The test that checks this behavior is overlay/037, still on my > overlayfs-devel branch. > > overlay/036 verifies that 2 *concurrent* overlay mount don't reuse the same > upper/work dir. The is enforced by overlayfs-next regardless on index feature. > A setup like this will cause troubles in old kernel as well, but mount > will not detect it. Thanks for the explanation! The commit log and test description don't provide enough background information. If you could resend with detailed explanation on the test, that'd be great! Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 12, 2017 at 2:46 PM, Eryu Guan <eguan@redhat.com> wrote: > On Wed, Jul 12, 2017 at 02:08:56PM +0300, Amir Goldstein wrote: >> On Wed, Jul 12, 2017 at 1:47 PM, Eryu Guan <eguan@redhat.com> wrote: >> > On Tue, Jul 11, 2017 at 10:52:06PM +0300, Amir Goldstein wrote: >> >> Expect EBUSY when trying to mount overlay when: >> >> - Upper dir is in-use by another overlay mount >> >> - Work dir is in-use by another overlay mount >> >> >> >> Signed-off-by: Amir Goldstein <amir73il@gmail.com> >> > >> > From patch 2/5, seems this behavior requires inode index feature to be >> > enabled, and now test fails on old kernels for me. Is this expected? >> > >> >> From my cover letter: >> "The new test overlay/036 checks for new overlay mount behaviors related >> to exclusivity of upper and work dirs among overlay mounts. This test >> is expected to fail on upstream kernel, but for a good reason, because >> the mount configurations that it tests (sharing upper dir among two >> overlay mounts) are not wise at all." >> >> So the answer is yes, this is expected and also does not depend >> on index feature. > > I usually read the cover letter (I saved it in my 'review' mailbox along > with patches to review), but somehow I forgot about it this time.. > >> >> I know this is a bit confusing, but inode index enforces that 2 >> *subsequent* overlay >> mount don't reuse the same upper/work dir with different lower/upper. >> The test that checks this behavior is overlay/037, still on my >> overlayfs-devel branch. >> >> overlay/036 verifies that 2 *concurrent* overlay mount don't reuse the same >> upper/work dir. The is enforced by overlayfs-next regardless on index feature. >> A setup like this will cause troubles in old kernel as well, but mount >> will not detect it. > > Thanks for the explanation! The commit log and test description don't > provide enough background information. If you could resend with detailed > explanation on the test, that'd be great! > No problem. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/overlay/036 b/tests/overlay/036 new file mode 100755 index 0000000..4100b80 --- /dev/null +++ b/tests/overlay/036 @@ -0,0 +1,82 @@ +#! /bin/bash +# FS QA Test 036 +# +# Test mount error cases with exclusive directories +# +# - Upper dir is in-use by another overlay mount +# - Work dir is in-use by another overlay mount +# +#----------------------------------------------------------------------- +# Copyright (C) 2017 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein <amir73il@gmail.com> +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + # unmount the two extra mounts in case they did not fail + $UMOUNT_PROG $SCRATCH_MNT 2>/dev/null + $UMOUNT_PROG $SCRATCH_MNT 2>/dev/null +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs overlay +_supported_os Linux +_require_scratch + +# Remove all files from previous tests +_scratch_mkfs + +# Create multiple lowerdirs, upperdirs and workdirs +lowerdir=$OVL_BASE_SCRATCH_MNT/lower +lowerdir2=$OVL_BASE_SCRATCH_MNT/lower2 +upperdir=$OVL_BASE_SCRATCH_MNT/upper +upperdir2=$OVL_BASE_SCRATCH_MNT/upper2 +workdir=$OVL_BASE_SCRATCH_MNT/workdir +workdir2=$OVL_BASE_SCRATCH_MNT/workdir2 +mkdir -p $lowerdir $lowerdir2 $upperdir $upperdir2 $workdir $workdir2 + +# Mount overlay with lowerdir, upperdir, workdir +_overlay_mount_dirs $lowerdir $upperdir $workdir \ + overlay1 $SCRATCH_MNT +# Try to mount another overlay with the same upperdir - expect EBUSY +_overlay_mount_dirs $lowerdir2 $upperdir $workdir2 \ + overlay2 $SCRATCH_MNT 2>&1 | _filter_scratch +# Try to mount another overlay with the same workdir - expect EBUSY +_overlay_mount_dirs $lowerdir2 $upperdir2 $workdir \ + overlay3 $SCRATCH_MNT 2>&1 | _filter_scratch + +# success, all done +status=0 +exit diff --git a/tests/overlay/036.out b/tests/overlay/036.out new file mode 100644 index 0000000..5174611 --- /dev/null +++ b/tests/overlay/036.out @@ -0,0 +1,3 @@ +QA output created by 036 +mount: overlay2 is already mounted or SCRATCH_MNT busy +mount: overlay3 is already mounted or SCRATCH_MNT busy diff --git a/tests/overlay/group b/tests/overlay/group index 87e3aaf..4cc1d74 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -38,3 +38,4 @@ 033 auto quick copyup hardlink 034 auto quick copyup hardlink 035 auto quick mount +036 auto quick mount
Expect EBUSY when trying to mount overlay when: - Upper dir is in-use by another overlay mount - Work dir is in-use by another overlay mount Signed-off-by: Amir Goldstein <amir73il@gmail.com> --- tests/overlay/036 | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/036.out | 3 ++ tests/overlay/group | 1 + 3 files changed, 86 insertions(+) create mode 100755 tests/overlay/036 create mode 100644 tests/overlay/036.out