| Message ID | 150957283171.18388.10837345130257598513.stgit@magnolia (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 01, 2017 at 02:47:11PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > The lvm command can invoke the thin pool utilities as part of managing > a thin volume. It'll fail if the thin provisioning utilities are not > installed, so we need to check for its presence before running a test. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > common/config | 1 + > tests/generic/459 | 1 + > 2 files changed, 2 insertions(+) > > > diff --git a/common/config b/common/config > index 96503c6..eea8669 100644 > --- a/common/config > +++ b/common/config > @@ -196,6 +196,7 @@ export MAN_PROG="`set_prog_path man`" > export NFS4_SETFACL_PROG="`set_prog_path nfs4_setfacl`" > export NFS4_GETFACL_PROG="`set_prog_path nfs4_getfacl`" > export UBIUPDATEVOL_PROG="`set_prog_path ubiupdatevol`" > +THIN_CHECK_PROG="$(set_prog_path thin_check)" I added an 'export' here. Thanks, Eryu > > # use 'udevadm settle' or 'udevsettle' to wait for lv to be settled. > # newer systems have udevadm command but older systems like RHEL5 don't. > diff --git a/tests/generic/459 b/tests/generic/459 > index 7c10c2a..d1ad372 100755 > --- a/tests/generic/459 > +++ b/tests/generic/459 > @@ -63,6 +63,7 @@ _supported_os Linux > _require_scratch_nocheck > _require_dm_target thin-pool > _require_command $LVM_PROG lvm > +_require_command "$THIN_CHECK_PROG" thin_check > _require_freeze > > # remove previous $seqres.full before test > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 02, 2017 at 08:25:14PM +0800, Eryu Guan wrote: > On Wed, Nov 01, 2017 at 02:47:11PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > The lvm command can invoke the thin pool utilities as part of managing > > a thin volume. It'll fail if the thin provisioning utilities are not > > installed, so we need to check for its presence before running a test. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > --- > > common/config | 1 + > > tests/generic/459 | 1 + > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/common/config b/common/config > > index 96503c6..eea8669 100644 > > --- a/common/config > > +++ b/common/config > > @@ -196,6 +196,7 @@ export MAN_PROG="`set_prog_path man`" > > export NFS4_SETFACL_PROG="`set_prog_path nfs4_setfacl`" > > export NFS4_GETFACL_PROG="`set_prog_path nfs4_getfacl`" > > export UBIUPDATEVOL_PROG="`set_prog_path ubiupdatevol`" > > +THIN_CHECK_PROG="$(set_prog_path thin_check)" > > I added an 'export' here. Oops, thanks for catching this. --D > > Thanks, > Eryu > > > > > # use 'udevadm settle' or 'udevsettle' to wait for lv to be settled. > > # newer systems have udevadm command but older systems like RHEL5 don't. > > diff --git a/tests/generic/459 b/tests/generic/459 > > index 7c10c2a..d1ad372 100755 > > --- a/tests/generic/459 > > +++ b/tests/generic/459 > > @@ -63,6 +63,7 @@ _supported_os Linux > > _require_scratch_nocheck > > _require_dm_target thin-pool > > _require_command $LVM_PROG lvm > > +_require_command "$THIN_CHECK_PROG" thin_check > > _require_freeze > > > > # remove previous $seqres.full before test > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/common/config b/common/config index 96503c6..eea8669 100644 --- a/common/config +++ b/common/config @@ -196,6 +196,7 @@ export MAN_PROG="`set_prog_path man`" export NFS4_SETFACL_PROG="`set_prog_path nfs4_setfacl`" export NFS4_GETFACL_PROG="`set_prog_path nfs4_getfacl`" export UBIUPDATEVOL_PROG="`set_prog_path ubiupdatevol`" +THIN_CHECK_PROG="$(set_prog_path thin_check)" # use 'udevadm settle' or 'udevsettle' to wait for lv to be settled. # newer systems have udevadm command but older systems like RHEL5 don't. diff --git a/tests/generic/459 b/tests/generic/459 index 7c10c2a..d1ad372 100755 --- a/tests/generic/459 +++ b/tests/generic/459 @@ -63,6 +63,7 @@ _supported_os Linux _require_scratch_nocheck _require_dm_target thin-pool _require_command $LVM_PROG lvm +_require_command "$THIN_CHECK_PROG" thin_check _require_freeze # remove previous $seqres.full before test