From patchwork Thu Jan 11 08:25:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 10157511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C989D601A1 for ; Thu, 11 Jan 2018 08:29:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE95127FB0 for ; Thu, 11 Jan 2018 08:29:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2EA428701; Thu, 11 Jan 2018 08:29:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5C8327FB0 for ; Thu, 11 Jan 2018 08:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932130AbeAKI3E (ORCPT ); Thu, 11 Jan 2018 03:29:04 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:55840 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932151AbeAKI3C (ORCPT ); Thu, 11 Jan 2018 03:29:02 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="35171430" Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 11 Jan 2018 16:28:59 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id ED6A648AEA11; Thu, 11 Jan 2018 16:29:00 +0800 (CST) Received: from RHEL7.5Alpha (10.167.220.29) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 11 Jan 2018 16:29:03 +0800 From: xiao yang To: CC: , xiao yang Subject: [PATCH] xfs: Regression test for invalid sb_logsunit Date: Thu, 11 Jan 2018 16:25:08 +0800 Message-ID: <1515659108-2222-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.167.220.29] X-yoursite-MailScanner-ID: ED6A648AEA11.AACDD X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If log stripe unit isn't a multiple of the fs blocksize and mounting, the invalid sb_logsunit leads to crash as soon as we try to write to the log. Signed-off-by: xiao yang --- tests/xfs/437 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/437.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 76 insertions(+) create mode 100755 tests/xfs/437 create mode 100644 tests/xfs/437.out diff --git a/tests/xfs/437 b/tests/xfs/437 new file mode 100755 index 0000000..96cec25 --- /dev/null +++ b/tests/xfs/437 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test No. 437 +# +# Regression test for commit: +# 9c92ee2 ("xfs: validate sb_logsunit is a multiple of the fs blocksize") +# +# If log stripe unit isn't a multiple of the fs blocksize and mounting, +# the invalid sb_logsunit leads to crash as soon as we try to write to +# the log. +# +#----------------------------------------------------------------------- +# Copyright (c) 2018 FUJITSU. All Rights Reserved. +# Author: Xiao Yang +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename "$0"` +seqres="$RESULT_DIR/$seq" +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -rf $tmp.* +} + +# get standard environment and checks +. ./common/rc + +# real QA test starts here +_supported_os Linux +_supported_fs xfs +_require_scratch + +rm -f "$seqres.full" + +# Format +_scratch_mkfs > $seqres.full 2>&1 || _fail "mkfs failed" + +# Set logsunit to a value which is not a multiple of the fs blocksize +blksz=$(_scratch_xfs_db -x -c "sb 0" -c "p blocksize") +_scratch_xfs_db -x -c "sb 0" -c "write logsunit $((blksz - 1))" \ + >> $seqres.full 2>&1 || _notrun "Failed to set sb_logsunit" + +# Mount and writing log may trigger a crash +if _scratch_mount >> $seqres.full 2>&1; then + for i in $(seq 1 1000); do + touch ${SCRATCH_MNT}/$i + done + _scratch_unmount +fi + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/xfs/437.out b/tests/xfs/437.out new file mode 100644 index 0000000..4dcb607 --- /dev/null +++ b/tests/xfs/437.out @@ -0,0 +1,2 @@ +QA output created by 437 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index d230060..35d1b03 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -434,3 +434,4 @@ 434 auto quick clone fsr 435 auto quick clone 436 auto quick clone fsr +437 auto quick log dangerous