From patchwork Wed Jan 24 23:53:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10183359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9C28E601E8 for ; Wed, 24 Jan 2018 23:53:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A54928994 for ; Wed, 24 Jan 2018 23:53:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F06A289B0; Wed, 24 Jan 2018 23:53:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21C6E28994 for ; Wed, 24 Jan 2018 23:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300AbeAXXxl (ORCPT ); Wed, 24 Jan 2018 18:53:41 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:52324 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932251AbeAXXxl (ORCPT ); Wed, 24 Jan 2018 18:53:41 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0ONqcZF039586; Wed, 24 Jan 2018 23:53:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=teQ+XLKDGxB2b14bGv8Q2IeP7jAlpwm3GsRCI5CHvg8=; b=khOOB4BqiACA+SrFdxjJwWym3HA2oPnafMhlO5FOA2MTytOle1Al68fcSvuFvVAbQV3d +DIIxEgHvMTTAXsw19Puf7WuyE8RUJvgEIHcMEca3UDCOsOXaECFXpFCRapgiL9OHkny 08v4aPlhfqw/UoU4PaTOiGcLCOWPRDO6tHJt4ZD/FUPmR72C4sYFKY83czLUKa+ja+nR H5oWPmOr/HIC6pLSMW6LA1NBn2Ei7BWyFr4m523voNNzpQdt2S858U01qnLe+TjYhGxf QES4qKpLvqvAGtH9zxUcv+aDeMVr2ITyCGV7eWkpwPZzosGjFjbfHgoOo+WQseYEdO3v Og== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2fq3nf05cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jan 2018 23:53:38 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w0ONrbEY010313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Jan 2018 23:53:37 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w0ONrbfX020518; Wed, 24 Jan 2018 23:53:37 GMT Received: from localhost (/10.159.137.211) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Jan 2018 15:53:36 -0800 Subject: [PATCH 3/5] generic/403: don't spew '$GETFATTR_PROG: Killed' messages From: "Darrick J. Wong" To: eguan@redhat.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Date: Wed, 24 Jan 2018 15:53:35 -0800 Message-ID: <151683801556.17051.2037237512407215800.stgit@magnolia> In-Reply-To: <151683799705.17051.9987269343206294671.stgit@magnolia> References: <151683799705.17051.9987269343206294671.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8784 signatures=668655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=553 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801240311 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Use a runfile presence check to control the background getfattr loop instead of using kill -9. This helps us to avoid the problem that the controlling bash will print a process killed message, which wrecks the golden output. Signed-off-by: Darrick J. Wong --- tests/generic/403 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/generic/403 b/tests/generic/403 index 17897ff..18fd1e5 100755 --- a/tests/generic/403 +++ b/tests/generic/403 @@ -61,7 +61,9 @@ touch $SCRATCH_MNT/file $SETFATTR_PROG -n trusted.small -v a $SCRATCH_MNT/file # start a background getxattr loop for the existing xattr -while [ true ]; do +runfile="$tmp.getfattr" +touch $runfile +while [ -e $runfile ]; do $GETFATTR_PROG --absolute-names -n trusted.small $SCRATCH_MNT/file \ > /dev/null || break done & @@ -75,7 +77,7 @@ for i in $(seq 0 99); do $SETFATTR_PROG -x trusted.big $SCRATCH_MNT/file done -kill -9 $getfattr_pid > /dev/null 2>&1 +rm -rf $runfile wait > /dev/null 2>&1 echo Silence is golden