| Message ID | 151683802170.17051.13989603221322920472.stgit@magnolia (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 24, 2018 at 03:53:41PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > These tests requires XFS debugging functionality, so test for that. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > tests/xfs/243 | 2 ++ > tests/xfs/245 | 2 ++ > tests/xfs/246 | 2 ++ > 3 files changed, 6 insertions(+) > > > diff --git a/tests/xfs/243 b/tests/xfs/243 > index 0bb69c4..1e6ab5a 100755 > --- a/tests/xfs/243 > +++ b/tests/xfs/243 > @@ -49,10 +49,12 @@ _cleanup() > . ./common/rc > . ./common/filter > . ./common/reflink > +. ./common/xfs This file should be included already by common/rc based on $FSTYP, no need to source it again in test. I'd remove it from all three tests on commit. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 25, 2018 at 04:17:53PM +0800, Eryu Guan wrote: > On Wed, Jan 24, 2018 at 03:53:41PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > These tests requires XFS debugging functionality, so test for that. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > --- > > tests/xfs/243 | 2 ++ > > tests/xfs/245 | 2 ++ > > tests/xfs/246 | 2 ++ > > 3 files changed, 6 insertions(+) > > > > > > diff --git a/tests/xfs/243 b/tests/xfs/243 > > index 0bb69c4..1e6ab5a 100755 > > --- a/tests/xfs/243 > > +++ b/tests/xfs/243 > > @@ -49,10 +49,12 @@ _cleanup() > > . ./common/rc > > . ./common/filter > > . ./common/reflink > > +. ./common/xfs > > This file should be included already by common/rc based on $FSTYP, no > need to source it again in test. I'd remove it from all three tests on > commit. Ok. Sorry I missed that subtlety. --D > Thanks, > Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/xfs/243 b/tests/xfs/243 index 0bb69c4..1e6ab5a 100755 --- a/tests/xfs/243 +++ b/tests/xfs/243 @@ -49,10 +49,12 @@ _cleanup() . ./common/rc . ./common/filter . ./common/reflink +. ./common/xfs # real QA test starts here _supported_os Linux _supported_fs xfs +_require_xfs_debug _require_scratch_reflink _require_xfs_io_command "falloc" _require_xfs_io_command "cowextsize" diff --git a/tests/xfs/245 b/tests/xfs/245 index c668eeb..d54f347 100755 --- a/tests/xfs/245 +++ b/tests/xfs/245 @@ -43,10 +43,12 @@ _cleanup() . ./common/rc . ./common/filter . ./common/reflink +. ./common/xfs # real QA test starts here _supported_os Linux _supported_fs xfs +_require_xfs_debug _require_scratch_reflink _require_xfs_io_command "falloc" _require_xfs_io_command "bmap" "-c" diff --git a/tests/xfs/246 b/tests/xfs/246 index 61d2545..c6ab603 100755 --- a/tests/xfs/246 +++ b/tests/xfs/246 @@ -38,10 +38,12 @@ _cleanup() # get standard environment, filters and checks . ./common/rc . ./common/filter +. ./common/xfs # real QA test starts here _supported_os Linux _supported_fs xfs +_require_xfs_debug _require_xfs_io_command "bmap" "-c" _require_scratch