From patchwork Sun May 6 06:36:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10382605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1977F60353 for ; Sun, 6 May 2018 06:34:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09E2628C5C for ; Sun, 6 May 2018 06:34:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F29A928C63; Sun, 6 May 2018 06:34:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E105B28C5C for ; Sun, 6 May 2018 06:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbeEFGer (ORCPT ); Sun, 6 May 2018 02:34:47 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:50430 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbeEFGeq (ORCPT ); Sun, 6 May 2018 02:34:46 -0400 Received: by mail-wm0-f67.google.com with SMTP id t11so9433255wmt.0; Sat, 05 May 2018 23:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CW19odDS3Jc1LkDn/Isvu/ZaEdq9APXylf9GaimL8dI=; b=QyEdNnJq/uoFVXojf6DFi7bfM3C+HSX2nCIVmNyAM/TGsdmcS5JPZDHGeERVC58dq4 zisca0/SFY65YpL3Doru4SXureK9PHo1tucOhYXBRyJ2G4yCbVF+sMdhK4H6sUWR47td jj7DX/BGJ1DinuOalT88JZScjt0nIwHJR2lulbarzvkTIxwckFHVWrT7E/DUd9O6HA/8 5asMxb7J+Ac9pgUAHQWav/PZYrx6TmlnLNNe6XKy+6bt9VfylojLc/aRZEz6gK24zg6y 4BmZ99j9S6EL5GPl4ymN5+busnKIulxAOu2dL52yvPPuRtStmPNLBkA+KbqXEz+2BeyD vZiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CW19odDS3Jc1LkDn/Isvu/ZaEdq9APXylf9GaimL8dI=; b=lJlytG0nhKHHJWqu3WozWX8iWnCUrpA9UREj0r499oFX/uduIrqpxE5HjASBe3gDsC /ZYDAlxF2WySE2PEr/hsdz2pLJiZ1MGCqgBmJDY6Uuo9s+YeK5GS+F4v9TE64tsPSTNh fxc0XhsxBQZoZx6hZFzPUL4Lim9/SpKPEF8WWQ1v7+8YqY1OcXHw7+tjT9ycsuDXpH0d 4moJNtpvfd+up8hwcukHoeOcrDzdb0hqbUQtdgWKy1tySulMF5n6SLt0CiBgO1mc0MfF 0wVlxRUNPfqzWTVT6kJ511FZvd10nVzChMrgUnr50avQt4/znX/5tWZCy+xWgWCH7QZm jKYQ== X-Gm-Message-State: ALQs6tC61pvUlQUA6ueAl8Yl7OD+ad/Z+8pjcyGkPV3YrzQHs7ogBO5E IFPr4mXCdAVo+d6Q5T9YKkc= X-Google-Smtp-Source: AB8JxZpQOv8yJPTgZ7lmLzFU/DRGqEYB39QzkUOew2pwOCBzFuK0IeTRDWykjZfzz8sT0D+RKiPEyw== X-Received: by 10.28.136.149 with SMTP id k143mr18568314wmd.17.1525588485192; Sat, 05 May 2018 23:34:45 -0700 (PDT) Received: from localhost.localdomain ([94.230.83.122]) by smtp.gmail.com with ESMTPSA id p17sm4174149wmc.17.2018.05.05.23.34.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 05 May 2018 23:34:44 -0700 (PDT) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH 2/2] generic/{159,160}: require chattr instead of lsattr Date: Sun, 6 May 2018 09:36:08 +0300 Message-Id: <1525588568-1714-3-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525588568-1714-1-git-send-email-amir73il@gmail.com> References: <1525588568-1714-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The tests _require_test_lsattr, but don't actually use lsattr. They use chattr +i/-i, so require the appropriate command. _require_test_lsattr checks the FS_IOC_GETFLAGS ioctl on a directory and that is not supported in overlayfs. _require_chattr checks the ioctl on a file, which is supported in overlayfs, so this change makes the tests run and pass on overlayfs. Signed-off-by: Amir Goldstein --- tests/generic/159 | 2 +- tests/generic/160 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/generic/159 b/tests/generic/159 index 7e52d5c..f517b55 100755 --- a/tests/generic/159 +++ b/tests/generic/159 @@ -43,7 +43,7 @@ _cleanup() # real QA test starts here _supported_os Linux -_require_test_lsattr +_require_chattr i _require_test_reflink rm -f $seqres.full diff --git a/tests/generic/160 b/tests/generic/160 index 409b15e..cd1044d 100755 --- a/tests/generic/160 +++ b/tests/generic/160 @@ -43,7 +43,7 @@ _cleanup() # real QA test starts here _supported_os Linux -_require_test_lsattr +_require_chattr i _require_test_dedupe rm -f $seqres.full