From patchwork Mon Mar 4 21:19:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10838615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 007451823 for ; Mon, 4 Mar 2019 21:19:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDFCE2AA53 for ; Mon, 4 Mar 2019 21:19:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D27142AB47; Mon, 4 Mar 2019 21:19:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F0F72AA53 for ; Mon, 4 Mar 2019 21:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbfCDVTU (ORCPT ); Mon, 4 Mar 2019 16:19:20 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:41952 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfCDVTU (ORCPT ); Mon, 4 Mar 2019 16:19:20 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x24LJDVD015310; Mon, 4 Mar 2019 21:19:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=tVNF0jlkf3ojvjpcraueMzkW/3XSffcC6DRLGO5kYM8=; b=HkPf5bOqb2rgzYjf0+9/JoZmY53y7pCONw8sOO48rgKL9QNp/dOqYuG2VLf4o8fsZMoO yjRd1Ewdj4XCdi8Z6Nb/vR7pfVJuQLRY2O1vX0AshtcZtb1iudS1a3+eYHl5w5sVKcYq hTI+7LqN30cY34RLH0oN7AK/JQuv+PAo77fIreK3CR1ipBQXf6N9FRW3GJ2L0RkOUPLI G5QJqFK1f1XbyyL8Ah5lVaygU+Mxj6BkGwVplVNX2T2wHVJg33agNcaPBfk+IoVZMNCp goj4FPZCcAScZeLX/Vv0DjDKAyxRaoZwydl4iY/2Vz7fj9pUJF1Dpr4ugdZtrtQTDW/K eA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2qyfbe1m1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Mar 2019 21:19:18 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x24LJH4H006244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Mar 2019 21:19:17 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x24LJHpE030628; Mon, 4 Mar 2019 21:19:17 GMT Received: from localhost (/10.159.248.244) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Mar 2019 13:19:17 -0800 Subject: [PATCH 1/5] common/rc: fix get_max_lfs_filesize From: "Darrick J. Wong" To: guaneryu@gmail.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Date: Mon, 04 Mar 2019 13:19:08 -0800 Message-ID: <155173434839.767.14812800687954592485.stgit@magnolia> In-Reply-To: <155173434205.767.15128498725168844621.stgit@magnolia> References: <155173434205.767.15128498725168844621.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9185 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=982 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903040150 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Helper functions are supposed to have a leading underscore ('_') in the function name, but this one doesn't have it. Unfortunately, the calling test cases (generic/349-351) /do/ have the leading underscore, so now they're broken. Signed-off-by: Darrick J. Wong --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index 8b40aabe..1c42515f 100644 --- a/common/rc +++ b/common/rc @@ -3834,7 +3834,7 @@ _get_max_file_size() } # get MAX_LFS_FILESIZE -get_max_lfs_filesize() +_get_max_lfs_filesize() { case "$(getconf LONG_BIT)" in "32")