diff mbox series

[3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures

Message ID 156394161274.1850833.4300015313269610610.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series xfs: fixes and new tests for bulkstat v5 | expand

Commit Message

Darrick J. Wong July 24, 2019, 4:13 a.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

The new v5 bulkstat and inumbers structures are correctly padded so that
no format changes are necessary across platforms, so add them to the
output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/122.out |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Brian Foster July 31, 2019, 11:40 a.m. UTC | #1 
On Tue, Jul 23, 2019 at 09:13:32PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> The new v5 bulkstat and inumbers structures are correctly padded so that
> no format changes are necessary across platforms, so add them to the
> output.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/xfs/122.out |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> 
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index cf9ac9e2..e2f346eb 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -66,6 +66,10 @@ sizeof(struct xfs_btree_block_lhdr) = 64
>  sizeof(struct xfs_btree_block_shdr) = 48
>  sizeof(struct xfs_bud_log_format) = 16
>  sizeof(struct xfs_bui_log_format) = 16
> +sizeof(struct xfs_bulk_ireq) = 64
> +sizeof(struct xfs_bulkstat) = 192
> +sizeof(struct xfs_bulkstat_req) = 64
> +sizeof(struct xfs_bulkstat_single_req) = 224
>  sizeof(struct xfs_clone_args) = 32
>  sizeof(struct xfs_cud_log_format) = 16
>  sizeof(struct xfs_cui_log_format) = 16
> @@ -89,6 +93,9 @@ sizeof(struct xfs_fsop_geom_v4) = 112
>  sizeof(struct xfs_icreate_log) = 28
>  sizeof(struct xfs_inode_log_format) = 56
>  sizeof(struct xfs_inode_log_format_32) = 52
> +sizeof(struct xfs_inumbers) = 24
> +sizeof(struct xfs_inumbers_req) = 64
> +sizeof(struct xfs_ireq) = 32

I don't see xfs_bulkstat_single_req or xfs_ireq in the latest kernel
headers. Do we still have those? Otherwise looks fine.

Brian

>  sizeof(struct xfs_log_dinode) = 176
>  sizeof(struct xfs_map_extent) = 32
>  sizeof(struct xfs_phys_extent) = 16
>
Darrick J. Wong July 31, 2019, 4:08 p.m. UTC | #2 
On Wed, Jul 31, 2019 at 07:40:20AM -0400, Brian Foster wrote:
> On Tue, Jul 23, 2019 at 09:13:32PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > The new v5 bulkstat and inumbers structures are correctly padded so that
> > no format changes are necessary across platforms, so add them to the
> > output.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  tests/xfs/122.out |    7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > 
> > diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> > index cf9ac9e2..e2f346eb 100644
> > --- a/tests/xfs/122.out
> > +++ b/tests/xfs/122.out
> > @@ -66,6 +66,10 @@ sizeof(struct xfs_btree_block_lhdr) = 64
> >  sizeof(struct xfs_btree_block_shdr) = 48
> >  sizeof(struct xfs_bud_log_format) = 16
> >  sizeof(struct xfs_bui_log_format) = 16
> > +sizeof(struct xfs_bulk_ireq) = 64
> > +sizeof(struct xfs_bulkstat) = 192
> > +sizeof(struct xfs_bulkstat_req) = 64
> > +sizeof(struct xfs_bulkstat_single_req) = 224
> >  sizeof(struct xfs_clone_args) = 32
> >  sizeof(struct xfs_cud_log_format) = 16
> >  sizeof(struct xfs_cui_log_format) = 16
> > @@ -89,6 +93,9 @@ sizeof(struct xfs_fsop_geom_v4) = 112
> >  sizeof(struct xfs_icreate_log) = 28
> >  sizeof(struct xfs_inode_log_format) = 56
> >  sizeof(struct xfs_inode_log_format_32) = 52
> > +sizeof(struct xfs_inumbers) = 24
> > +sizeof(struct xfs_inumbers_req) = 64
> > +sizeof(struct xfs_ireq) = 32
> 
> I don't see xfs_bulkstat_single_req or xfs_ireq in the latest kernel
> headers. Do we still have those? Otherwise looks fine.

Ooops, I forgot to remove those, will fix.

--D

> Brian
> 
> >  sizeof(struct xfs_log_dinode) = 176
> >  sizeof(struct xfs_map_extent) = 32
> >  sizeof(struct xfs_phys_extent) = 16
> >
diff mbox series

Patch

diff --git a/tests/xfs/122.out b/tests/xfs/122.out
index cf9ac9e2..e2f346eb 100644
--- a/tests/xfs/122.out
+++ b/tests/xfs/122.out
@@ -66,6 +66,10 @@  sizeof(struct xfs_btree_block_lhdr) = 64
 sizeof(struct xfs_btree_block_shdr) = 48
 sizeof(struct xfs_bud_log_format) = 16
 sizeof(struct xfs_bui_log_format) = 16
+sizeof(struct xfs_bulk_ireq) = 64
+sizeof(struct xfs_bulkstat) = 192
+sizeof(struct xfs_bulkstat_req) = 64
+sizeof(struct xfs_bulkstat_single_req) = 224
 sizeof(struct xfs_clone_args) = 32
 sizeof(struct xfs_cud_log_format) = 16
 sizeof(struct xfs_cui_log_format) = 16
@@ -89,6 +93,9 @@  sizeof(struct xfs_fsop_geom_v4) = 112
 sizeof(struct xfs_icreate_log) = 28
 sizeof(struct xfs_inode_log_format) = 56
 sizeof(struct xfs_inode_log_format_32) = 52
+sizeof(struct xfs_inumbers) = 24
+sizeof(struct xfs_inumbers_req) = 64
+sizeof(struct xfs_ireq) = 32
 sizeof(struct xfs_log_dinode) = 176
 sizeof(struct xfs_map_extent) = 32
 sizeof(struct xfs_phys_extent) = 16