diff mbox series

[23/24] generic/204: sync before scrub hits EIO

Message ID 160013432161.2923511.669329888874845585.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: tons of random fixes | expand

Commit Message

Darrick J. Wong Sept. 15, 2020, 1:45 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Let's see if we can prevent fs corruption warnings by flushing dirty
data to disk before the test ends.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/generic/204 |    1 +
 1 file changed, 1 insertion(+)

Comments

Zorro Lang Sept. 16, 2020, 12:09 p.m. UTC | #1
On Mon, Sep 14, 2020 at 06:45:21PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Let's see if we can prevent fs corruption warnings by flushing dirty
> data to disk before the test ends.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

At least it won't break more things:)
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/204 |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/tests/generic/204 b/tests/generic/204
> index 7250c00a..22d6fed5 100755
> --- a/tests/generic/204
> +++ b/tests/generic/204
> @@ -18,6 +18,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  _cleanup()
>  {
>  	rm -f $tmp.*
> +	sync
>  }
>  
>  # get standard environment, filters and checks
>
Christoph Hellwig Sept. 17, 2020, 8:01 a.m. UTC | #2
On Mon, Sep 14, 2020 at 06:45:21PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Let's see if we can prevent fs corruption warnings by flushing dirty
> data to disk before the test ends.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/generic/204 b/tests/generic/204
index 7250c00a..22d6fed5 100755
--- a/tests/generic/204
+++ b/tests/generic/204
@@ -18,6 +18,7 @@  trap "_cleanup; exit \$status" 0 1 2 3 15
 _cleanup()
 {
 	rm -f $tmp.*
+	sync
 }
 
 # get standard environment, filters and checks