| Message ID | 1602382464-1230-1-git-send-email-xuyang2018.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic/611: Filter getfattr output | expand |
On Sun, Oct 11, 2020 at 10:14:24AM +0800, Yang Xu wrote: > When using old version(such as getfattr 2.4.46) getfattr command, it > has the following output, > > touch file > setfattr -n user.a file > getfattr --absolute-names -n user.a file > user.a > > on new getfattr, it reports the following output, > getfattr --absolute-names -n user.a file > user.a="" There's an helper to do this, _getfattr, so use it here instead of bare $GETFATTR_PROG. For details please refer to commit 794f4594fbf4 ("fstests: filter redundant output by getfattr") Thanks, Eryu > > Filter doubt quotes and equals, so this case can pass. > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > --- > tests/generic/611 | 2 +- > tests/generic/611.out | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/generic/611 b/tests/generic/611 > index f4158bb3..c697b39a 100755 > --- a/tests/generic/611 > +++ b/tests/generic/611 > @@ -51,7 +51,7 @@ touch "${localfile}" > _scratch_cycle_mount > > # If the target bug isn't fixed, getfattr fails > -${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a' > +${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a' | sed 's/=""//g' > > status=0 > exit > diff --git a/tests/generic/611.out b/tests/generic/611.out > index 1ab12434..8ccf52f0 100644 > --- a/tests/generic/611.out > +++ b/tests/generic/611.out > @@ -1,2 +1,2 @@ > QA output created by 611 > -user.a="" > +user.a > -- > 2.23.0 > >
diff --git a/tests/generic/611 b/tests/generic/611 index f4158bb3..c697b39a 100755 --- a/tests/generic/611 +++ b/tests/generic/611 @@ -51,7 +51,7 @@ touch "${localfile}" _scratch_cycle_mount # If the target bug isn't fixed, getfattr fails -${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a' +${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a' | sed 's/=""//g' status=0 exit diff --git a/tests/generic/611.out b/tests/generic/611.out index 1ab12434..8ccf52f0 100644 --- a/tests/generic/611.out +++ b/tests/generic/611.out @@ -1,2 +1,2 @@ QA output created by 611 -user.a="" +user.a
When using old version(such as getfattr 2.4.46) getfattr command, it has the following output, touch file setfattr -n user.a file getfattr --absolute-names -n user.a file user.a on new getfattr, it reports the following output, getfattr --absolute-names -n user.a file user.a="" Filter doubt quotes and equals, so this case can pass. Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- tests/generic/611 | 2 +- tests/generic/611.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)