Message ID | 160382530205.1202316.9303713563959751852.stgit@magnolia (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | xfstests: random fixes | expand |
On Tue, Oct 27, 2020 at 12:01:42PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > This is a regression test for a specific bug that requires a specific > configuration of the data device. Realtime volumes and external logs > don't affect the efficacy of the test, but the test can fail mkfs if the > realtime device is very large. > > Therefore, unset USE_EXTERNAL so that we always run this regression > test, even if the tester enabled realtime. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/tests/xfs/520 b/tests/xfs/520 index 51bc4100..b99b9c6e 100755 --- a/tests/xfs/520 +++ b/tests/xfs/520 @@ -41,6 +41,9 @@ _disable_dmesg_check _require_check_dmesg _require_scratch_nocheck +# Don't let the rtbitmap fill up the data device and screw up this test +unset USE_EXTERNAL + force_crafted_metadata() { _scratch_mkfs_xfs -f $fsdsopt "$4" >> $seqres.full 2>&1 || _fail "mkfs failed" _scratch_xfs_set_metadata_field "$1" "$2" "$3" >> $seqres.full 2>&1