| Message ID | 1619151838-22476-1-git-send-email-xuyang2018.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs/144: Use _qsetup instead of qsetup | expand |
On Fri, Apr 23, 2021 at 12:23:58PM +0800, Yang Xu wrote: > Since xfstests commit 56908a2eb566c5("common/quota: move _qsetup() helper to common code"), > we have common _qsetup function. Even this case doesn't use enforce value like xfs/050 and xfs/299, > using _qsetup is more meaningful. So remove useless qsetup. > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > tests/xfs/144 | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/tests/xfs/144 b/tests/xfs/144 > index c5995cc5..74988090 100755 > --- a/tests/xfs/144 > +++ b/tests/xfs/144 > @@ -38,25 +38,6 @@ _require_scratch > > rm -f $seqres.full > > -qsetup() > -{ > - opt=$1 > - enforce=0 > - if [ $opt = "u" -o $opt = "uno" ]; then > - type=u > - eval `_choose_uid` > - elif [ $opt = "g" -o $opt = "gno" ]; then > - type=g > - eval `_choose_gid` > - elif [ $opt = "p" -o $opt = "pno" ]; then > - type=p > - eval `_choose_prid` > - fi > - [ $opt = "u" -o $opt = "g" -o $opt = "p" ] && enforce=1 > - > - echo "Using type=$type id=$id" >> $seqres.full > -} > - > exercise() { > _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs > cat $tmp.mkfs >>$seqres.full > @@ -66,7 +47,7 @@ exercise() { > > _qmount > > - qsetup $1 > + _qsetup $1 > > echo "Using type=$type id=$id" >>$seqres.full > > -- > 2.23.0 >
diff --git a/tests/xfs/144 b/tests/xfs/144 index c5995cc5..74988090 100755 --- a/tests/xfs/144 +++ b/tests/xfs/144 @@ -38,25 +38,6 @@ _require_scratch rm -f $seqres.full -qsetup() -{ - opt=$1 - enforce=0 - if [ $opt = "u" -o $opt = "uno" ]; then - type=u - eval `_choose_uid` - elif [ $opt = "g" -o $opt = "gno" ]; then - type=g - eval `_choose_gid` - elif [ $opt = "p" -o $opt = "pno" ]; then - type=p - eval `_choose_prid` - fi - [ $opt = "u" -o $opt = "g" -o $opt = "p" ] && enforce=1 - - echo "Using type=$type id=$id" >> $seqres.full -} - exercise() { _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full @@ -66,7 +47,7 @@ exercise() { _qmount - qsetup $1 + _qsetup $1 echo "Using type=$type id=$id" >>$seqres.full
Since xfstests commit 56908a2eb566c5("common/quota: move _qsetup() helper to common code"), we have common _qsetup function. Even this case doesn't use enforce value like xfs/050 and xfs/299, using _qsetup is more meaningful. So remove useless qsetup. Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> --- tests/xfs/144 | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-)