diff mbox series

[3/3] new: don't allow new tests in group 'other'

Message ID 163183920637.953189.13037781612178012211.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: various cleanups to ./new script | expand

Commit Message

Darrick J. Wong Sept. 17, 2021, 12:40 a.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

The 'other' group is vaguely defined at best -- other than what?  It's
not clear what tests belong in this group, and it has become a dumping
ground for random stuff that are classified in other groups.  Don't let
people create new other group tests.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 new |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Amir Goldstein Sept. 17, 2021, 10:42 a.m. UTC | #1
On Fri, Sep 17, 2021 at 12:57 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> From: Darrick J. Wong <djwong@kernel.org>
>
> The 'other' group is vaguely defined at best -- other than what?  It's
> not clear what tests belong in this group, and it has become a dumping
> ground for random stuff that are classified in other groups.  Don't let
> people create new other group tests.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  new |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
>
> diff --git a/new b/new
> index 3a657d20..9651e0e0 100755
> --- a/new
> +++ b/new
> @@ -100,6 +100,9 @@ check_groups() {
>                         echo "Invalid characters in group(s): ${inval}"
>                         echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
>                         return 1
> +               elif [ "${g}" = "other" ]; then
> +                       echo "Do not add more tests to group \"other\""
> +                       return 1
>                 elif ! group_names | grep -q -w "${g}"; then
>                         echo "Warning: group \"${g}\" not defined in documentation"
>                         return 1
> @@ -111,16 +114,16 @@ check_groups() {
>
>  if [ $# -eq 0 ]; then
>         # interactive mode
> -       prompt="Add to group(s) [other] (separate by space, ? for list): "
> +       prompt="Add to group(s) [auto] (separate by space, ? for list): "
>         while true; do
>                 read -p "${prompt}" -a new_groups || exit 1
>                 case "${#new_groups[@]}" in
>                 0)
> -                       new_groups=("other")
> +                       new_groups=("auto")
>                         ;;
>                 1)
>                         if [ "${new_groups[0]}" = "?" ]; then
> -                               echo $(group_names)
> +                               echo $(group_names | grep -v -w 'other')
>                                 continue
>                         fi
>                         ;;
>

Darrick,

Thanks for the first cleanup and for this extra cleanup.
I wanted to point out that with this patch there is no implication
to filtering out "other" in group_names() SHOULD you think
this is better. I definitely have no problem with the patch as is!

Thanks,
Amir.
diff mbox series

Patch

diff --git a/new b/new
index 3a657d20..9651e0e0 100755
--- a/new
+++ b/new
@@ -100,6 +100,9 @@  check_groups() {
 			echo "Invalid characters in group(s): ${inval}"
 			echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
 			return 1
+		elif [ "${g}" = "other" ]; then
+			echo "Do not add more tests to group \"other\""
+			return 1
 		elif ! group_names | grep -q -w "${g}"; then
 			echo "Warning: group \"${g}\" not defined in documentation"
 			return 1
@@ -111,16 +114,16 @@  check_groups() {
 
 if [ $# -eq 0 ]; then
 	# interactive mode
-	prompt="Add to group(s) [other] (separate by space, ? for list): "
+	prompt="Add to group(s) [auto] (separate by space, ? for list): "
 	while true; do
 		read -p "${prompt}" -a new_groups || exit 1
 		case "${#new_groups[@]}" in
 		0)
-			new_groups=("other")
+			new_groups=("auto")
 			;;
 		1)
 			if [ "${new_groups[0]}" = "?" ]; then
-				echo $(group_names)
+				echo $(group_names | grep -v -w 'other')
 				continue
 			fi
 			;;