| Message ID | 1669198883-16-1-git-send-email-yangx.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs/243: add _require_scratch_delalloc() | expand |
On Wed, Nov 23, 2022 at 10:21:23AM +0000, Xiao Yang wrote: > xfs/243 requires the delalloc feature of XFS so return [not run] > when XFS with enabled DAX doesn't support it. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > --- Looks good to me, this case starts to fail from xfs dax supports reflink. Reviewed-by: Zorro Lang <zlang@redhat.com> > tests/xfs/243 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/xfs/243 b/tests/xfs/243 > index 8f0c5939..739efe4a 100755 > --- a/tests/xfs/243 > +++ b/tests/xfs/243 > @@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch > _supported_fs xfs > _require_xfs_debug > _require_scratch_reflink > +_require_scratch_delalloc > _require_xfs_io_command "falloc" > _require_xfs_io_command "cowextsize" > _require_xfs_io_command "fpunch" > -- > 2.34.1 >
Hi zorro, Is it OK to merge the patch? Best Regards, Xiao Yang -----Original Message----- From: Zorro Lang <zlang@redhat.com> Sent: 2022年11月24日 0:27 To: Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> Cc: fstests@vger.kernel.org Subject: Re: [PATCH] xfs/243: add _require_scratch_delalloc() On Wed, Nov 23, 2022 at 10:21:23AM +0000, Xiao Yang wrote: > xfs/243 requires the delalloc feature of XFS so return [not run] when > XFS with enabled DAX doesn't support it. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > --- Looks good to me, this case starts to fail from xfs dax supports reflink. Reviewed-by: Zorro Lang <zlang@redhat.com> > tests/xfs/243 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/xfs/243 b/tests/xfs/243 index 8f0c5939..739efe4a > 100755 > --- a/tests/xfs/243 > +++ b/tests/xfs/243 > @@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch _supported_fs > xfs _require_xfs_debug _require_scratch_reflink > +_require_scratch_delalloc > _require_xfs_io_command "falloc" > _require_xfs_io_command "cowextsize" > _require_xfs_io_command "fpunch" > -- > 2.34.1 >
On Sat, Dec 17, 2022 at 09:33:41AM +0000, yangx.jy@fujitsu.com wrote: > Hi zorro, > > Is it OK to merge the patch? Thanks for ping me, I'll merge this patch. Thanks, Zorro > > Best Regards, > Xiao Yang > > -----Original Message----- > From: Zorro Lang <zlang@redhat.com> > Sent: 2022年11月24日 0:27 > To: Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> > Cc: fstests@vger.kernel.org > Subject: Re: [PATCH] xfs/243: add _require_scratch_delalloc() > > On Wed, Nov 23, 2022 at 10:21:23AM +0000, Xiao Yang wrote: > > xfs/243 requires the delalloc feature of XFS so return [not run] when > > XFS with enabled DAX doesn't support it. > > > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > > --- > > Looks good to me, this case starts to fail from xfs dax supports reflink. > > Reviewed-by: Zorro Lang <zlang@redhat.com> > > > tests/xfs/243 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/xfs/243 b/tests/xfs/243 index 8f0c5939..739efe4a > > 100755 > > --- a/tests/xfs/243 > > +++ b/tests/xfs/243 > > @@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch _supported_fs > > xfs _require_xfs_debug _require_scratch_reflink > > +_require_scratch_delalloc > > _require_xfs_io_command "falloc" > > _require_xfs_io_command "cowextsize" > > _require_xfs_io_command "fpunch" > > -- > > 2.34.1 > > >
diff --git a/tests/xfs/243 b/tests/xfs/243 index 8f0c5939..739efe4a 100755 --- a/tests/xfs/243 +++ b/tests/xfs/243 @@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch _supported_fs xfs _require_xfs_debug _require_scratch_reflink +_require_scratch_delalloc _require_xfs_io_command "falloc" _require_xfs_io_command "cowextsize" _require_xfs_io_command "fpunch"
xfs/243 requires the delalloc feature of XFS so return [not run] when XFS with enabled DAX doesn't support it. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- tests/xfs/243 | 1 + 1 file changed, 1 insertion(+)