From patchwork Fri Dec 30 22:19:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 13085206 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AEBC4332F for ; Sat, 31 Dec 2022 00:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235866AbiLaAnl (ORCPT ); Fri, 30 Dec 2022 19:43:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235863AbiLaAnk (ORCPT ); Fri, 30 Dec 2022 19:43:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F03F1DDE2; Fri, 30 Dec 2022 16:43:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 10160B81E64; Sat, 31 Dec 2022 00:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0818C433D2; Sat, 31 Dec 2022 00:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672447416; bh=dy/KuTYnPHg68gvnNcfCdYdlzMOoGb8xpPsjnMBtGig=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jXP8weDwSmiLiUI4eIbz9p6/Q8dVBj98TCWltjMUMiNRH3HZn+lp1wrf9RpT2TCkh dkxJ2t/T81u+bZitf1lDuUH2cxFVoJeHWlHuzvmBPYvbWeeydcHE8McTwzkwJRg3ar FhnsX++XizCJn2X9cfqvITJVJKBzIaGKGhn4Y4uA6GW6BqxJP1xKzecnpdLleLyS5+ Egi3pgeHcYEDQNFF3CPYPtEbhvhZaCrTN3NolbrO6a3T0a04uEet9+Fbqfn52G+ReW dN5GdRGqXTWMNwIt7DG+EeqSgUl8RBCpArYxTuOQrm0nL7eKkWAe/sjwunS6IBqtUo mDVWg9NeKXVPg== Subject: [PATCH 1/1] xfs/422: don't freeze while racing rmap repair and fsstress From: "Darrick J. Wong" To: zlang@redhat.com, djwong@kernel.org Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Fri, 30 Dec 2022 14:19:33 -0800 Message-ID: <167243877357.728215.3478300804915017773.stgit@magnolia> In-Reply-To: <167243877345.728215.12907289289488316002.stgit@magnolia> References: <167243877345.728215.12907289289488316002.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong Since we're moving away from freezing the filesystem for rmap repair, remove the freeze/thaw race from this test to make it more interesting. Signed-off-by: Darrick J. Wong Reviewed-by: Zorro Lang --- tests/xfs/422 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/xfs/422 b/tests/xfs/422 index 995f612166..339f12976a 100755 --- a/tests/xfs/422 +++ b/tests/xfs/422 @@ -5,8 +5,6 @@ # FS QA Test No. 422 # # Race fsstress and rmapbt repair for a while to see if we crash or livelock. -# rmapbt repair requires us to freeze the filesystem to stop all filesystem -# activity, so we can't have userspace wandering in and thawing it. # . ./common/preamble _begin_fstest online_repair dangerous_fsstress_repair freeze @@ -31,7 +29,7 @@ _require_xfs_stress_online_repair _scratch_mkfs > "$seqres.full" 2>&1 _scratch_mount _require_xfs_has_feature "$SCRATCH_MNT" rmapbt -_scratch_xfs_stress_online_repair -f -s "repair rmapbt %agno%" +_scratch_xfs_stress_online_repair -s "repair rmapbt %agno%" # success, all done echo Silence is golden