[07/10] xfs/503: test metadump obfuscation, not progressbars

Commit Message

Darrick J. Wong Jan. 25, 2024, 7:05 p.m. UTC

From: Darrick J. Wong <[e-mail]>

The -g switch to xfs_metadump turns on progress reporting, but nothing
in this test actually checks that it works.

The -o switch turns off obfuscation, which is much more critical to
support teams.

Change this test to check -o and -ao instead of -g or -ag.

Signed-off-by: Darrick J. Wong <[e-mail]>
---
 tests/xfs/503     |   10 +++++-----
 tests/xfs/503.out |    4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Christoph Hellwig Jan. 26, 2024, 1:35 p.m. UTC | #1

Looks good:

Reviewed-by: Christoph Hellwig <[e-mail]>

Patch

diff --git a/tests/xfs/503 b/tests/xfs/503
index ff6b344a9c..79bbbdd26d 100755
--- a/tests/xfs/503
+++ b/tests/xfs/503
@@ -47,16 +47,16 @@  metadump_file=$testdir/scratch.md
 copy_file=$testdir/copy.img
 
 echo "metadump and mdrestore"
-_verify_metadumps '-a -o'
+_verify_metadumps
 
 echo "metadump a and mdrestore"
 _verify_metadumps '-a'
 
-echo "metadump g and mdrestore"
-_verify_metadumps '-g' >> $seqres.full
+echo "metadump o and mdrestore"
+_verify_metadumps '-o'
 
-echo "metadump ag and mdrestore"
-_verify_metadumps '-a -g' >> $seqres.full
+echo "metadump ao and mdrestore"
+_verify_metadumps '-a -o'
 
 echo copy
 $XFS_COPY_PROG $SCRATCH_DEV $copy_file >> $seqres.full
diff --git a/tests/xfs/503.out b/tests/xfs/503.out
index 496f2516e4..5e7488456d 100644
--- a/tests/xfs/503.out
+++ b/tests/xfs/503.out
@@ -2,7 +2,7 @@  QA output created by 503
 Format and populate
 metadump and mdrestore
 metadump a and mdrestore
-metadump g and mdrestore
-metadump ag and mdrestore
+metadump o and mdrestore
+metadump ao and mdrestore
 copy
 recopy