diff mbox series

[4/8] generic/491: increase test timeout

Message ID 170899915276.896550.7065004814140508980.stgit@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series [1/8] generic/604: try to make race occur reliably | expand

Commit Message

Darrick J. Wong Feb. 27, 2024, 2:01 a.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Bump the read timeout in this test to a few seconds just in case it
actually takes the IO system more than a second to retrieve the data
(e.g. cloud storage network lag).

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/491 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Feb. 27, 2024, 4:28 a.m. UTC | #1
On Mon, Feb 26, 2024 at 06:01:34PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Bump the read timeout in this test to a few seconds just in case it
> actually takes the IO system more than a second to retrieve the data
> (e.g. cloud storage network lag).
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/491 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/tests/generic/491 b/tests/generic/491
> index 797b08d506..5a586c122a 100755
> --- a/tests/generic/491
> +++ b/tests/generic/491
> @@ -44,7 +44,7 @@ xfs_freeze -f $SCRATCH_MNT
>  
>  # Read file while filesystem is frozen should succeed
>  # without blocking
> -$TIMEOUT_PROG -s KILL 1s cat $testfile
> +$TIMEOUT_PROG -s KILL 5s cat $testfile
>  
>  xfs_freeze -u $SCRATCH_MNT
>  
>
Christoph Hellwig Feb. 27, 2024, 2:53 p.m. UTC | #2
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/generic/491 b/tests/generic/491
index 797b08d506..5a586c122a 100755
--- a/tests/generic/491
+++ b/tests/generic/491
@@ -44,7 +44,7 @@  xfs_freeze -f $SCRATCH_MNT
 
 # Read file while filesystem is frozen should succeed
 # without blocking
-$TIMEOUT_PROG -s KILL 1s cat $testfile
+$TIMEOUT_PROG -s KILL 5s cat $testfile
 
 xfs_freeze -u $SCRATCH_MNT