diff mbox series

[2/2] xfs/122: add tests for commitrange structures

Message ID 172780126049.3586479.7813790327650448381.stgit@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [1/2] src/fiexchange.h: add the start-commit/commit-range ioctls | expand

Commit Message

Darrick J. Wong Oct. 1, 2024, 4:49 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Update this test to check the ioctl structure for XFS_IOC_COMMIT_RANGE.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/122.out |    1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Oct. 2, 2024, 5:45 a.m. UTC | #1 
On Tue, Oct 01, 2024 at 09:49:27AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Update this test to check the ioctl structure for XFS_IOC_COMMIT_RANGE.

Meh.  Can we please not add more to xfs/122, as that's alway just
a pain?  We can just static_assert the size in xfsprogs (or the
xfstests code using it) instead of this mess.
Darrick J. Wong Oct. 2, 2024, 10:47 p.m. UTC | #2 
On Tue, Oct 01, 2024 at 10:45:50PM -0700, Christoph Hellwig wrote:
> On Tue, Oct 01, 2024 at 09:49:27AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Update this test to check the ioctl structure for XFS_IOC_COMMIT_RANGE.
> 
> Meh.  Can we please not add more to xfs/122, as that's alway just
> a pain?  We can just static_assert the size in xfsprogs (or the
> xfstests code using it) instead of this mess.

Oh right, we had a plan to autotranslate the xfs/122 stuff to
xfs_ondisk.h didn't we... I'll put that back on my list.

--D
Christoph Hellwig Oct. 3, 2024, 12:10 p.m. UTC | #3 
On Wed, Oct 02, 2024 at 03:47:00PM -0700, Darrick J. Wong wrote:
> Oh right, we had a plan to autotranslate the xfs/122 stuff to
> xfs_ondisk.h didn't we... I'll put that back on my list.

xfs_ondisk.h should be fully covered.  You pointed out that were
are missing ioctls, though.  Let me find some time to add those
as well.
diff mbox series

Patch

diff --git a/tests/xfs/122.out b/tests/xfs/122.out
index 60d8294551..4dc7d7d0a3 100644
--- a/tests/xfs/122.out
+++ b/tests/xfs/122.out
@@ -76,6 +76,7 @@  sizeof(struct xfs_bulk_ireq) = 64
 sizeof(struct xfs_bulkstat) = 192
 sizeof(struct xfs_bulkstat_req) = 64
 sizeof(struct xfs_clone_args) = 32
+sizeof(struct xfs_commit_range) = 88
 sizeof(struct xfs_cud_log_format) = 16
 sizeof(struct xfs_cui_log_format) = 16
 sizeof(struct xfs_da3_blkinfo) = 56