| Message ID | 173870406352.546134.8739392016656606912.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/34] generic/476: fix fsstress process management | expand |
On Tue, Feb 04, 2025 at 01:26:29PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > As I've noted elsewhere, the use of process session ids to "isolate" > test instances from killing each other is kind of hacky and creates > other weird side effects. I'd rather everyone use the new code that > runs everything in proper isolation with private pid and mount > namespaces, but I don't know how many people this would break were it a > hard dependency. > > Deprecate the process session handling immediately with a warning that > we're going to rip it out in a year. > > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Ok, that answers some of the questions I raised - the session-id support is time limited and makes people very aware of it. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/check b/check index 24b21cf139f927..5beb10612b75fb 100755 --- a/check +++ b/check @@ -692,6 +692,15 @@ function _adjust_oom_score() { } _adjust_oom_score -500 +warn_deprecated_sessionid() +{ + if [ -z "$WARNED_DEPRECATED_SESSIONID" ]; then + echo "WARNING: Running fstests without private pid/mount namespace" + echo "support is deprecated and will be removed in February 2026." + WARNED_DEPRECATED_SESSIONID=1 + fi +} + # ...and make the tests themselves somewhat more attractive to it, so that if # the system runs out of memory it'll be the test that gets killed and not the # test framework. The test is run in a separate process without any of our @@ -891,6 +900,8 @@ function run_section() seqres="$check" _check_test_fs + test -n "$HAVE_PRIVATENS" || warn_deprecated_sessionid + loop_status=() # track rerun-on-failure state local tc_status ix local -a _list=( $list )