| Message ID | 173870406442.546134.7449017953421049612.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/34] generic/476: fix fsstress process management | expand |
On Tue, Feb 04, 2025 at 01:28:02PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Prior to commit 8973af00ec21, in the absence of an explicit > SOAK_DURATION, this test would run 2500 fsstress operations each of ten > times through the loop body. On the author's machines, this kept the > runtime to about 30s total. Oddly, this was changed to 30s per loop > body with no specific justification in the middle of an fsstress process > management change. > > On the author's machine, this explodes the runtime from ~30s to 420s. > Put things back the way they were. > > Cc: <fstests@vger.kernel.org> # v2024.12.08 > Fixes: 8973af00ec212f ("fstests: cleanup fsstress process management") > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> > --- > tests/generic/650 | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > > diff --git a/tests/generic/650 b/tests/generic/650 > index 60f86fdf518961..2e051b73156842 100755 > --- a/tests/generic/650 > +++ b/tests/generic/650 > @@ -68,11 +68,11 @@ test "$nr_cpus" -gt 1024 && nr_cpus="$nr_hotplug_cpus" > fsstress_args+=(-p $nr_cpus) > if [ -n "$SOAK_DURATION" ]; then > test "$SOAK_DURATION" -lt 10 && SOAK_DURATION=10 > + fsstress_args+=(--duration="$((SOAK_DURATION / 10))") > else > - # run for 30s per iteration max > - SOAK_DURATION=300 > + # run for 3s per iteration max for a default runtime of ~30s. > + fsstress_args+=(--duration=3) Works for me. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/tests/generic/650 b/tests/generic/650 index 60f86fdf518961..2e051b73156842 100755 --- a/tests/generic/650 +++ b/tests/generic/650 @@ -68,11 +68,11 @@ test "$nr_cpus" -gt 1024 && nr_cpus="$nr_hotplug_cpus" fsstress_args+=(-p $nr_cpus) if [ -n "$SOAK_DURATION" ]; then test "$SOAK_DURATION" -lt 10 && SOAK_DURATION=10 + fsstress_args+=(--duration="$((SOAK_DURATION / 10))") else - # run for 30s per iteration max - SOAK_DURATION=300 + # run for 3s per iteration max for a default runtime of ~30s. + fsstress_args+=(--duration=3) fi -fsstress_args+=(--duration="$((SOAK_DURATION / 10))") nr_ops=$((2500 * TIME_FACTOR)) fsstress_args+=(-n $nr_ops)