diff mbox

more reflink fixes

Message ID 20160204154552.GA31510@lst.de (mailing list archive)
State New, archived
Headers show

Commit Message

Christoph Hellwig Feb. 4, 2016, 3:45 p.m. UTC
And another one:

---
From 36919b5d1c84b0ceb8b9fc5c33ec1730d10e5d1c Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Thu, 4 Feb 2016 16:42:12 +0100
Subject: xfstests: don't run 907 and 908 on NFS

NFS can't interrupt pending clone operations as they are a remote
operation.  Skip the two tests that rely on this as they'll mess up
all following tests otherwise.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/907 | 2 ++
 tests/generic/908 | 2 ++
 2 files changed, 4 insertions(+)

Comments

Darrick J. Wong Feb. 4, 2016, 5:27 p.m. UTC | #1
On Thu, Feb 04, 2016 at 04:45:52PM +0100, Christoph Hellwig wrote:
> And another one:
> 
> ---
> From 36919b5d1c84b0ceb8b9fc5c33ec1730d10e5d1c Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Thu, 4 Feb 2016 16:42:12 +0100
> Subject: xfstests: don't run 907 and 908 on NFS
> 
> NFS can't interrupt pending clone operations as they are a remote
> operation.  Skip the two tests that rely on this as they'll mess up
> all following tests otherwise.

Applied, thanks.

--D

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/907 | 2 ++
>  tests/generic/908 | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/tests/generic/907 b/tests/generic/907
> index fec22c8..e35e067 100755
> --- a/tests/generic/907
> +++ b/tests/generic/907
> @@ -47,6 +47,8 @@ _require_scratch_reflink
>  _require_cp_reflink
>  _require_command "$(which timeout)" "timeout"
>  
> +test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
> +
>  rm -f "$seqres.full"
>  
>  echo "Format and mount"
> diff --git a/tests/generic/908 b/tests/generic/908
> index 09a3101..c977ed6 100755
> --- a/tests/generic/908
> +++ b/tests/generic/908
> @@ -47,6 +47,8 @@ _require_scratch_reflink
>  _require_cp_reflink
>  _require_command "$(which timeout)" "timeout"
>  
> +test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
> +
>  rm -f "$seqres.full"
>  
>  echo "Format and mount"
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/generic/907 b/tests/generic/907
index fec22c8..e35e067 100755
--- a/tests/generic/907
+++ b/tests/generic/907
@@ -47,6 +47,8 @@  _require_scratch_reflink
 _require_cp_reflink
 _require_command "$(which timeout)" "timeout"
 
+test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
+
 rm -f "$seqres.full"
 
 echo "Format and mount"
diff --git a/tests/generic/908 b/tests/generic/908
index 09a3101..c977ed6 100755
--- a/tests/generic/908
+++ b/tests/generic/908
@@ -47,6 +47,8 @@  _require_scratch_reflink
 _require_cp_reflink
 _require_command "$(which timeout)" "timeout"
 
+test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
+
 rm -f "$seqres.full"
 
 echo "Format and mount"