From patchwork Fri Feb 19 01:33:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Chinner X-Patchwork-Id: 8355311 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E074F9F38B for ; Fri, 19 Feb 2016 01:33:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 12ECE203AB for ; Fri, 19 Feb 2016 01:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 370FA203B5 for ; Fri, 19 Feb 2016 01:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948093AbcBSBdp (ORCPT ); Thu, 18 Feb 2016 20:33:45 -0500 Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:63680 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948079AbcBSBdp (ORCPT ); Thu, 18 Feb 2016 20:33:45 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DXBwDtb8ZW/5bY03ZegzqBP4Jpo2UBAQEBAQEGi3GFSIQIhgcCAgEBAoFlTQEBAQEBAWUnhEIBAQQ6HCMQCAMOCgklDwUlAyETiBm8EwEBAQcCAR0YhTKFA4QQCoRVBYdWjy+NUY58jkdig3coLodngTgBAQE Received: from ppp118-211-216-150.lns20.syd4.internode.on.net (HELO dastard) ([118.211.216.150]) by ipmail05.adl6.internode.on.net with ESMTP; 19 Feb 2016 12:03:17 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1aWZwa-0001Rt-Uo; Fri, 19 Feb 2016 12:33:16 +1100 Date: Fri, 19 Feb 2016 12:33:16 +1100 From: Dave Chinner To: Zorro Lang Cc: fstests@vger.kernel.org, eguan@redhat.com Subject: Re: [PATCH] xfs: change return value check to golden image check Message-ID: <20160219013316.GW14668@dastard> References: <1455208656-16637-1-git-send-email-zlang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1455208656-16637-1-git-send-email-zlang@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 12, 2016 at 12:37:36AM +0800, Zorro Lang wrote: > xfs/133 and xfs/138 use too much code to do "return value" check, > it's not necessary. For the code can be more readable and clear, > I change "return value" check to golden image check. > > Signed-off-by: Zorro Lang > --- > tests/xfs/133 | 20 +++++++------------- > tests/xfs/133.out | 7 +++++++ > tests/xfs/138 | 26 ++++++++++++-------------- > tests/xfs/138.out | 12 ++++++++++++ > 4 files changed, 38 insertions(+), 27 deletions(-) This cause a xfs/133 failure like this on my systems: Can you see if you can reproduce it? Cheers, Dave. --- tests/xfs/133.out 2016-02-19 10:40:57.043131919 +1100 +++ /home/dave/src/xfstests-dev/results//xfs/xfs/133.out.bad 2016-02-19 12:24:53.173589432 +1100 @@ -4,5 +4,6 @@ Filesystem Blocks Quota Limit Warn/Time Mounted on SCRATCH_DEV 0 102400 204800 00 [--------] SCRATCH_MNT === report command output === +(null) 0 0 0 00 [--------] 123456-project 0 102400 204800 00 [--------]