From patchwork Thu Aug 18 15:04:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Whitney X-Patchwork-Id: 9289301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C197607FF for ; Fri, 19 Aug 2016 04:04:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07EDF28E8E for ; Fri, 19 Aug 2016 04:04:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0CF828EEF; Fri, 19 Aug 2016 04:04:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6928428E8E for ; Fri, 19 Aug 2016 04:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbcHSEEo (ORCPT ); Fri, 19 Aug 2016 00:04:44 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:34812 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbcHSEEn (ORCPT ); Fri, 19 Aug 2016 00:04:43 -0400 Received: by mail-qk0-f193.google.com with SMTP id r128so3758957qkc.1; Thu, 18 Aug 2016 21:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=wIyXlPzI42KBXFrdhpCEdFctsGnYk9M4r0uiQeM3Bl0=; b=VFP2xSkBYlSuasKLdZcvQlmAchQZNrCv1OG5qL+Zeqg7Ohgog4ids8nc+D/w26i+35 cmibluvC8aV4aWht49CgdqIDUqHkWxdiOsbMfhbmPlDw0ldTqYfZDe83glBw7xcWWlOf xNBQaY+46uiLF6R0WtIncKeGt8yfjdr6cPLUlK2QRkbfvXRKDZeLiWSHU7EQL9TDPAee /dqgyJeAgkVLmu8Ohqrwd89WK7YZlhf902vROvHTUhlmUxZy9jiv6S+TvOXCAsoqFI5Z j7qSCoper70uddW8C9uMrWp2sw9tIbhtawJpPG5ZywM+S+1EOHjptlKjLAbAyyWQerHz vLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=wIyXlPzI42KBXFrdhpCEdFctsGnYk9M4r0uiQeM3Bl0=; b=K8EK94qr2iuunwwsCSUaEwwQIiVkWzSCJuPHITE7L2NtHkaMMpRZoCsCS8p8uM9yV4 lPNgGceyi6l7szkjd7WN82UKRmiBJ0JqyMysKh7pNDlACjdfB/ssAINbBHau/W4y4xlf hoj7JHkiDI5uH4PQplT7yuRRhVCncMz0M/aBhbItiXZG75LyUsNCEKvD8euLyTOMv1JS Z/QP21ACt17RFE8LteeQnDDEyze3+IhNaMRu+lK+okFGOYdoV5tcIz7OhU3HnZUVJCDM GQxqswlU8pkBo4jDs0muP1m7KIjFcoIAzO9qpMRnqT/oSpsTMZ5PXqD0VKZl/Jm6FzmE 0T0g== X-Gm-Message-State: AEkoous0O0NL0IbjFO8IETHrS9FTLRnhm8J/wDR0bH6oPuenSWivvaHM9CdAUPjbxIWGDw== X-Received: by 10.55.101.17 with SMTP id z17mr2825912qkb.186.1471532480376; Thu, 18 Aug 2016 08:01:20 -0700 (PDT) Received: from localhost.localdomain (c-50-187-52-22.hsd1.nh.comcast.net. [50.187.52.22]) by smtp.gmail.com with ESMTPSA id j38sm1249406qtj.35.2016.08.18.08.01.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Aug 2016 08:01:19 -0700 (PDT) Date: Thu, 18 Aug 2016 11:04:56 -0400 From: Eric Whitney To: fstests@vger.kernel.org Cc: linux-ext4@vger.kernel.org, tytso@mit.edu Subject: [PATCH] generic/135: redirect stderr from _scratch_mkfs Message-ID: <20160818150456.GB14069@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In generic/135, benign warning message output from _scratch_mkfs on stderr can cause a golden output mismatch, as can occur when testing an ext4 bigalloc file system. It's the only generic test that does not also redirect stderr when directing _scratch_mkfs' stdout to /dev/null. Since error output from _scratch_mkfs doesn't seem important to the overall intent of the test, there should be no harm in making its stderr handling consistent. Signed-off-by: Eric Whitney --- tests/generic/135 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/135 b/tests/generic/135 index 52418f6..14b8132 100755 --- a/tests/generic/135 +++ b/tests/generic/135 @@ -41,7 +41,7 @@ _supported_os Linux IRIX _require_odirect _require_scratch -_scratch_mkfs >/dev/null +_scratch_mkfs >/dev/null 2>&1 _scratch_mount cd $SCRATCH_MNT