diff mbox

xfs/348: update error message when transmogrifying symlink into directory

Message ID 20170413153942.GA5083@birch.djwong.org (mailing list archive)
State New, archived
Headers show

Commit Message

Darrick J. Wong April 13, 2017, 3:39 p.m. UTC
We introduced the inline directory verifier in 4.11 to prevent the
system from trying to use corrupt inline directories.  This has the
effect of changing the error message in one step of the i_mode fuzz
tester, so update the test accordingly.

Note that prior to the existence of the verifier, this test would
occasionally result in memory corruption that did not become evident
until later.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/348.out |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Christoph Hellwig April 13, 2017, 6:17 p.m. UTC | #1
On Thu, Apr 13, 2017 at 08:39:43AM -0700, Darrick J. Wong wrote:
> We introduced the inline directory verifier in 4.11 to prevent the
> system from trying to use corrupt inline directories.  This has the
> effect of changing the error message in one step of the i_mode fuzz
> tester, so update the test accordingly.
> 
> Note that prior to the existence of the verifier, this test would
> occasionally result in memory corruption that did not become evident
> until later.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/xfs/348.out b/tests/xfs/348.out
index 805d530..f4a7a71 100644
--- a/tests/xfs/348.out
+++ b/tests/xfs/348.out
@@ -110,7 +110,7 @@  would have junked entry "FIFO" in directory PARENT_INO
 stat: 'SCRATCH_MNT/test/DIR' is a directory
 stat: 'SCRATCH_MNT/test/DATA' is a directory
 stat: cannot stat 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
-stat: 'SCRATCH_MNT/test/SYMLINK' is a directory
+stat: cannot stat 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/BLKDEV': Structure needs cleaning
 stat: cannot stat 'SCRATCH_MNT/test/FIFO': Structure needs cleaning