diff mbox

kvm-xfstests: unmount /results before shutting down

Message ID 20170501170420.94456-1-ebiggers3@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Biggers May 1, 2017, 5:04 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

kvm-xfstests shuts down the VM with 'poweroff -f', which with old
versions of systemd's 'poweroff' command (including the version included
in Debian Jessie) does not call sync().  This could cause data written
to the /results filesystem to be lost.  Work around this by unmounting
/results before shutting down.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 1 +
 1 file changed, 1 insertion(+)

Comments

Theodore Ts'o May 2, 2017, 4:42 a.m. UTC | #1 
On Mon, May 01, 2017 at 10:04:20AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> kvm-xfstests shuts down the VM with 'poweroff -f', which with old
> versions of systemd's 'poweroff' command (including the version included
> in Debian Jessie) does not call sync().  This could cause data written
> to the /results filesystem to be lost.  Work around this by unmounting
> /results before shutting down.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

				- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
index 2eb3a2b..cd01ffd 100755
--- a/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
+++ b/kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot
@@ -92,6 +92,7 @@  then
 	/bin/rm -f /run/gce-finalize-wait
     else
 	/root/runtests.sh
+	umount /results
 	poweroff -f > /dev/null 2>&1
     fi
 else